From: Simon Horman <simon.horman@corigine•com>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
David Miller <davem@davemloft•net>,
Realtek linux nic maintainers <nic_swsd@realtek•com>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] r8169: use dev_err_probe in all appropriate places in rtl_init_one()
Date: Thu, 1 Jun 2023 17:44:02 +0200 [thread overview]
Message-ID: <ZHi8worgk2KndZPd@corigine.com> (raw)
In-Reply-To: <f0596a19-d517-e301-b649-304f9247b75a@gmail.com>
On Wed, May 31, 2023 at 10:41:32PM +0200, Heiner Kallweit wrote:
> In addition to properly handling probe deferrals dev_err_probe()
> conveniently combines printing an error message with returning
> the errno. So let's use it for every error path in rtl_init_one()
> to simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2023-06-01 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 20:41 [PATCH net-next] r8169: use dev_err_probe in all appropriate places in rtl_init_one() Heiner Kallweit
2023-06-01 15:44 ` Simon Horman [this message]
2023-06-02 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHi8worgk2KndZPd@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nic_swsd@realtek$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox