From: Simon Horman <simon.horman@corigine•com>
To: Amritha Nambiar <amritha.nambiar@intel•com>
Cc: netdev@vger•kernel.org, kuba@kernel•org, davem@davemloft•net,
sridhar.samudrala@intel•com
Subject: Re: [net-next/RFC PATCH v1 4/4] netdev-genl: Add support for exposing napi info from netdev
Date: Fri, 2 Jun 2023 17:47:17 +0200 [thread overview]
Message-ID: <ZHoPBYx2lZJ+i1LC@corigine.com> (raw)
In-Reply-To: <168564136118.7284.18138054610456895287.stgit@anambiarhost.jf.intel.com>
On Thu, Jun 01, 2023 at 10:42:41AM -0700, Amritha Nambiar wrote:
> Add support in ynl/netdev.yaml for napi related information. The
> netdev structure tracks all the napi instances and napi fields.
> The napi instances and associated queue[s] can be retrieved this way.
>
> Refactored netdev-genl to support exposing napi<->queue[s] mapping
> that is retained in a netdev.
Hi Amritha,
This feels like it should be two patches to me.
Though it is not something I feel strongly about.
> Signed-off-by: Amritha Nambiar <amritha.nambiar@intel•com>
...
> +static int
> +netdev_nl_dev_napi_prepare_fill(struct net_device *netdev,
> + struct sk_buff **pskb, u32 portid, u32 seq,
> + int flags, u32 cmd, enum netdev_nl_type type)
> +{
> + struct nlmsghdr *nlh;
> + struct sk_buff *skb = *pskb;
> + bool last = false;
> + int index = 0;
> + void *hdr;
> + int err;
> +
nit: please use reverse xmas tree - longest line to shortest - for
local variable declarations in (new) Networking code.
...
next prev parent reply other threads:[~2023-06-02 15:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 17:42 [net-next/RFC PATCH v1 0/4] Introduce napi queues support Amritha Nambiar
2023-06-01 17:42 ` [net-next/RFC PATCH v1 1/4] net: Introduce new napi fields for rx/tx queues Amritha Nambiar
2023-06-03 6:06 ` Jakub Kicinski
2023-07-12 20:09 ` Nambiar, Amritha
2023-07-12 21:14 ` Jakub Kicinski
2023-07-12 23:11 ` Nambiar, Amritha
2023-07-12 23:53 ` Jakub Kicinski
2023-07-28 21:59 ` Jakub Kicinski
2023-07-28 22:37 ` Nambiar, Amritha
2023-07-28 23:09 ` Jakub Kicinski
2023-07-31 23:48 ` Nambiar, Amritha
2023-08-02 0:26 ` David Ahern
2023-08-02 0:50 ` Jakub Kicinski
2023-06-01 17:42 ` [net-next/RFC PATCH v1 2/4] net: Add support for associating napi with queue[s] Amritha Nambiar
2023-06-02 15:42 ` Simon Horman
2023-07-12 19:53 ` Nambiar, Amritha
2023-06-03 6:31 ` Paolo Abeni
2023-07-12 19:56 ` Nambiar, Amritha
2023-06-01 17:42 ` [net-next/RFC PATCH v1 3/4] netdev-genl: Introduce netdev dump ctx Amritha Nambiar
2023-06-01 17:42 ` [net-next/RFC PATCH v1 4/4] netdev-genl: Add support for exposing napi info from netdev Amritha Nambiar
2023-06-02 15:47 ` Simon Horman [this message]
2023-06-03 6:08 ` Jakub Kicinski
2023-07-12 20:05 ` Nambiar, Amritha
2023-07-12 19:54 ` Nambiar, Amritha
2023-06-03 6:17 ` Jakub Kicinski
2023-07-12 20:10 ` Nambiar, Amritha
2023-07-12 21:19 ` Jakub Kicinski
2023-06-03 6:00 ` [net-next/RFC PATCH v1 0/4] Introduce napi queues support Jakub Kicinski
2023-07-12 19:52 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHoPBYx2lZJ+i1LC@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=amritha.nambiar@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox