From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>
Cc: netdev <netdev@vger•kernel.org>,
Heiner Kallweit <hkallweit1@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Oleksij Rempel <linux@rempel-privat•de>
Subject: Re: [PATCH v4 net-next 1/9] net: phy-c45: Fix genphy_c45_ethtool_set_eee description
Date: Sun, 18 Jun 2023 20:18:42 +0100 [thread overview]
Message-ID: <ZI9YkpEsaCj+cDqP@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230618184119.4017149-2-andrew@lunn.ch>
On Sun, Jun 18, 2023 at 08:41:11PM +0200, Andrew Lunn wrote:
> The text has been cut/paste from genphy_c45_ethtool_get_eee but not
> changed to reflect it performs set.
>
> Additionally, extend the comment. This function implements the logic
> that eee_enabled has global control over EEE. When eee_enabled is
> false, no link modes will be advertised, and as a result, the MAC
> should not transmit LPI.
>
> Signed-off-by: Andrew Lunn <andrew@lunn•ch>
> ---
> drivers/net/phy/phy-c45.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
> index fee514b96ab1..d1d7cf34ac0b 100644
> --- a/drivers/net/phy/phy-c45.c
> +++ b/drivers/net/phy/phy-c45.c
> @@ -1425,12 +1425,15 @@ int genphy_c45_ethtool_get_eee(struct phy_device *phydev,
> EXPORT_SYMBOL(genphy_c45_ethtool_get_eee);
>
> /**
> - * genphy_c45_ethtool_set_eee - get EEE supported and status
> + * genphy_c45_ethtool_set_eee - set EEE supported and status
> * @phydev: target phy_device struct
> * @data: ethtool_eee data
> *
> - * Description: it reportes the Supported/Advertisement/LP Advertisement
> - * capabilities.
> + * Description: it set the Supported/Advertisement/LP Advertisement
Description: sets the ...
> + * capabilities. If eee_enabled is false, no links modes are
> + * advertised, but the previously advertised link modes are
I'd suggest moving "advertised," to the preceding line to fill it
more...
> + * retained. This allows EEE to be enabled/disabled in a none
> + * destructive way.
which then would allow "non-destructive" here rather than the slightly
more awkward (but correct) "non-
destructive" formatting here.
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-18 19:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 18:41 [PATCH v4 net-next 0/9] net: ethernet: Rework EEE Andrew Lunn
2023-06-18 18:41 ` [PATCH v4 net-next 1/9] net: phy-c45: Fix genphy_c45_ethtool_set_eee description Andrew Lunn
2023-06-18 19:18 ` Russell King (Oracle) [this message]
2023-06-18 20:30 ` Andrew Lunn
2023-06-18 18:41 ` [PATCH v4 net-next 2/9] net: add helpers for EEE configuration Andrew Lunn
2023-06-19 15:26 ` Florian Fainelli
2023-06-18 18:41 ` [PATCH v4 net-next 3/9] net: phy: Add phydev->enable_tx_lpi to simplify adjust link callbacks Andrew Lunn
2023-06-18 18:41 ` [PATCH v4 net-next 4/9] net: phy: Add helper to set EEE Clock stop enable bit Andrew Lunn
2023-06-18 18:41 ` [PATCH v4 net-next 5/9] net: phy: Keep track of EEE configuration Andrew Lunn
2023-06-18 19:20 ` Russell King (Oracle)
2023-06-19 14:20 ` Simon Horman
2023-06-19 15:27 ` Florian Fainelli
2023-06-18 18:41 ` [PATCH v4 net-next 6/9] net: phy: Immediately call adjust_link if only tx_lpi_enabled changes Andrew Lunn
2023-06-18 18:41 ` [PATCH v4 net-next 7/9] net: phy: Add phy_support_eee() indicating MAC support EEE Andrew Lunn
2023-06-19 15:21 ` Florian Fainelli
2023-06-22 15:20 ` Russell King (Oracle)
2023-06-22 15:43 ` Andrew Lunn
2023-06-18 18:41 ` [PATCH v4 net-next 8/9] net: fec: Move fec_enet_eee_mode_set() and helper earlier Andrew Lunn
2023-06-19 15:22 ` Florian Fainelli
2023-06-18 18:41 ` [PATCH v4 net-next 9/9] net: fec: Fixup EEE Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI9YkpEsaCj+cDqP@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux@rempel-privat$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox