From: Simon Horman <simon.horman@corigine•com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
Cc: s.shtylyov@omp•ru, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, maciej.fijalkowski@intel•com,
netdev@vger•kernel.org, linux-renesas-soc@vger•kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: renesas: rswitch: Use hardware pause features
Date: Wed, 7 Jun 2023 17:23:57 +0200 [thread overview]
Message-ID: <ZIChDe2LHcP1Ux+O@corigine.com> (raw)
In-Reply-To: <20230607015641.1724057-3-yoshihiro.shimoda.uh@renesas.com>
On Wed, Jun 07, 2023 at 10:56:41AM +0900, Yoshihiro Shimoda wrote:
> Since this driver used the "global rate limiter" feature of GWCA,
> the TX perfromance of each port was reduced when multiple ports
Hi Shimoda-san,
a very minor nit, in case you have to do a v4 for some other reason:
perfromance -> performance
> transmitted frames simultaneously. To improve perfromance, remove
Here too.
> the use of the "global rate limiter" feature and use "hardware pause"
> features of the following:
> - "per priority pause" of GWCA
> - "global pause" of COMA
>
> Note that these features are not related to the ethernet PAUSE frame.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
...
next prev parent reply other threads:[~2023-06-07 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 1:56 [PATCH net-next v3 0/2] net: renesas: rswitch: Improve perfromance of TX/RX Yoshihiro Shimoda
2023-06-07 1:56 ` [PATCH net-next v3 1/2] net: renesas: rswitch: Use napi_gro_receive() in RX Yoshihiro Shimoda
2023-06-07 1:56 ` [PATCH net-next v3 2/2] net: renesas: rswitch: Use hardware pause features Yoshihiro Shimoda
2023-06-07 11:09 ` Maciej Fijalkowski
2023-06-07 15:23 ` Simon Horman [this message]
2023-06-07 23:57 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIChDe2LHcP1Ux+O@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=s.shtylyov@omp$(echo .)ru \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox