From: Simon Horman <simon.horman@corigine•com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
Cc: s.shtylyov@omp•ru, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, netdev@vger•kernel.org,
linux-renesas-soc@vger•kernel.org,
Phong Hoang <phong.hoang.wz@renesas•com>
Subject: Re: [PATCH net v2] net: renesas: rswitch: Fix timestamp feature after all descriptors are used
Date: Wed, 7 Jun 2023 17:25:41 +0200 [thread overview]
Message-ID: <ZIChdcJ1e2cl5epK@corigine.com> (raw)
In-Reply-To: <20230607070141.1795982-1-yoshihiro.shimoda.uh@renesas.com>
On Wed, Jun 07, 2023 at 04:01:41PM +0900, Yoshihiro Shimoda wrote:
> The timestamp descriptors were intended to act cyclically. Descriptors
> from index 0 through gq->ring_size - 1 contain actual information, and
> the last index (gq->ring_size) should have LINKFIX to indicate
> the first index 0 descriptor. However, thie LINKFIX value is missing,
Hi Shimoda-san,
a very minor nit, in case you end up posting a v3 for some other reason:
thie -> the
> causing the timestamp feature to stop after all descriptors are used.
> To resolve this issue, set the LINKFIX to the timestamp descritors.
>
> Reported-by: Phong Hoang <phong.hoang.wz@renesas•com>
> Fixes: 33f5d733b589 ("net: renesas: rswitch: Improve TX timestamp accuracy")
...
next prev parent reply other threads:[~2023-06-07 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 7:01 [PATCH net v2] net: renesas: rswitch: Fix timestamp feature after all descriptors are used Yoshihiro Shimoda
2023-06-07 11:27 ` Hao Lan
2023-06-08 0:20 ` Yoshihiro Shimoda
2023-06-08 0:57 ` Yoshihiro Shimoda
2023-06-08 13:30 ` Hao Lan
2023-06-07 15:25 ` Simon Horman [this message]
2023-06-08 0:21 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIChdcJ1e2cl5epK@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=phong.hoang.wz@renesas$(echo .)com \
--cc=s.shtylyov@omp$(echo .)ru \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox