From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>, Heiner Kallweit <hkallweit1@gmail•com>
Cc: Alexander Couzens <lynxis@fe80•eu>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Cc: Claudiu Beznea <claudiu.beznea@microchip•com>,
Daniel Golle <daniel@makrotopia•org>,
Daniel Machon <daniel.machon@microchip•com>,
"David S. Miller" <davem@davemloft•net>,
DENG Qingfang <dqfext@gmail•com>,
Eric Dumazet <edumazet@google•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Horatiu Vultur <horatiu.vultur@microchip•com>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Jakub Kicinski <kuba@kernel•org>,
Jose Abreu <Jose.Abreu@synopsys•com>,
Landen Chao <Landen.Chao@mediatek•com>,
Lars Povlsen <lars.povlsen@microchip•com>,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org,
Madalin Bucur <madalin.bucur@nxp•com>,
Marcin Wojtas <mw@semihalf•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
Michal Simek <michal.simek@amd•com>,
netdev@vger•kernel.org,
Nicolas Ferre <nicolas.ferre@microchip•com>,
Paolo Abeni <pabeni@redhat•com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx•com>,
Sean Anderson <sean.anderson@seco•com>,
Sean Wang <sean.wang@mediatek•com>,
Steen Hegelund <Steen.Hegelund@microchip•com>,
Taras Chornyi <taras.chornyi@plvision•eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
UNGLinuxDriver@microchip•com, Vladimir Oltean <olteanv@gmail•com>
Subject: [PATCH RFC 0/15] Add and use helper for PCS negotiation modes
Date: Tue, 13 Jun 2023 15:36:56 +0100 [thread overview]
Message-ID: <ZIh/CLQ3z89g0Ua0@shell.armlinux.org.uk> (raw)
Hi,
Earlier this month, I proposed a helper for deciding whether a PCS
should use inband negotiation modes or not. There was some discussion
around this topic, and I believe there was no disagreement about
providing the helper.
The initial discussion can be found at:
https://lore.kernel.org/r/ZGIkGmyL8yL1q1zp@shell.armlinux.org.uk
Subsequently, I posted a RFC series back in May:
https://lore.kernel.org/r/ZGzhvePzPjJ0v2En@shell.armlinux.org.uk
that added a helper, phylink_pcs_neg_mode() which PCS drivers could use
to parse the state, and updated a bunch of drivers to use it. I got
a couple of bits of feedback to it, including some ACKs.
However, I've decided to take this slightly further and change the
"mode" parameter to both the pcs_config() and pcs_link_up() methods
when a PCS driver opts in to this (by setting "neg_mode" in the
phylink_pcs structure.) If this is not set, we default to the old
behaviour. That said, this series converts all the PCS implementations
I can find currently in net-next.
Doing this has the added benefit that the negotiation mode parameter
is also available to the pcs_link_up() function, which can now know
whether inband negotiation was in fact enabled or not at pcs_config()
time.
Consequently, because the driver implementations have changed, I've
dropped the acks I received previously.
I've build-tested this, but I can't guarantee having build-tested
every change.
drivers/net/dsa/qca/qca8k-8xxx.c | 13 ++-
drivers/net/dsa/sja1105/sja1105_main.c | 14 ++-
drivers/net/ethernet/freescale/fman/fman_dtsec.c | 7 +-
drivers/net/ethernet/marvell/mvneta.c | 7 +-
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 +--
.../net/ethernet/marvell/prestera/prestera_main.c | 11 +--
.../net/ethernet/microchip/lan966x/lan966x_main.c | 1 +
.../ethernet/microchip/lan966x/lan966x_phylink.c | 7 +-
.../net/ethernet/microchip/sparx5/sparx5_main.c | 1 +
.../net/ethernet/microchip/sparx5/sparx5_phylink.c | 8 +-
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +-
drivers/net/pcs/pcs-lynx.c | 48 +++++----
drivers/net/pcs/pcs-mtk-lynxi.c | 39 +++-----
drivers/net/pcs/pcs-xpcs.c | 43 ++++----
drivers/net/phy/phylink.c | 59 +++++++----
include/linux/pcs/pcs-xpcs.h | 4 +-
include/linux/phylink.h | 109 +++++++++++++++++++--
17 files changed, 253 insertions(+), 138 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2023-06-13 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 14:36 Russell King (Oracle) [this message]
2023-06-13 14:37 ` [PATCH RFC net-next 01/15] net: phylink: add PCS negotiation mode Russell King (Oracle)
2023-06-13 15:55 ` Simon Horman
2023-06-13 14:37 ` [PATCH RFC net-next 02/15] net: phylink: convert phylink_mii_c22_pcs_config() to neg_mode Russell King (Oracle)
2023-06-13 14:37 ` [PATCH RFC net-next 03/15] net: phylink: pass neg_mode into phylink_mii_c22_pcs_config() Russell King (Oracle)
2023-06-13 14:37 ` [PATCH RFC net-next 04/15] net: pcs: xpcs: update PCS driver to use neg_mode Russell King (Oracle)
2023-06-13 14:37 ` [PATCH RFC net-next 05/15] net: pcs: lynxi: " Russell King (Oracle)
2023-06-13 14:37 ` [PATCH RFC net-next 06/15] net: pcs: lynx: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 07/15] net: lan966x: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 08/15] net: mvneta: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 09/15] net: mvpp2: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 10/15] net: prestera: " Russell King (Oracle)
2023-06-13 16:17 ` [EXT] " Elad Nachman
2023-06-13 14:38 ` [PATCH RFC net-next 11/15] net: qca8k: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 12/15] net: sparx5: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 13/15] net: dsa: b53: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 14/15] net: dsa: mt7530: " Russell King (Oracle)
2023-06-13 14:38 ` [PATCH RFC net-next 15/15] net: macb: " Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIh/CLQ3z89g0Ua0@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=Jose.Abreu@synopsys$(echo .)com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=claudiu.beznea@microchip$(echo .)com \
--cc=daniel.machon@microchip$(echo .)com \
--cc=daniel@makrotopia$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lars.povlsen@microchip$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=lynxis@fe80$(echo .)eu \
--cc=madalin.bucur@nxp$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=michal.simek@amd$(echo .)com \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=radhey.shyam.pandey@xilinx$(echo .)com \
--cc=sean.anderson@seco$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=taras.chornyi@plvision$(echo .)eu \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox