From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Vladimir Oltean <olteanv@gmail•com>
Cc: arinc9.unal@gmail•com, "Arınç ÜNAL" <arinc.unal@arinc9•com>,
"Daniel Golle" <daniel@makrotopia•org>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Sean Wang" <sean.wang@mediatek•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora•com>,
"Frank Wunderlich" <frank-w@public-files•de>,
"Bartel Eerdekens" <bartel.eerdekens@constell8•be>,
mithat.guner@xeront•com, erkin.bozoglu@xeront•com,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org
Subject: Re: [PATCH net v5 2/6] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch
Date: Fri, 16 Jun 2023 11:17:54 +0100 [thread overview]
Message-ID: <ZIw20jmqI1d/W+YY@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230616100314.x2qak6t7uxo2qnja@skbuf>
On Fri, Jun 16, 2023 at 01:03:14PM +0300, Vladimir Oltean wrote:
> On Fri, Jun 16, 2023 at 05:53:23AM +0300, arinc9.unal@gmail•com wrote:
> > From: Arınç ÜNAL <arinc.unal@arinc9•com>
> >
> > The check for setting the CPU_PORT bits must include the non-MT7621 SoC
> > MT7530 switch variants to trap frames. Expand the check to include them.
> >
> > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9•com>
> > ---
>
> why do you say non-MT7621 when the change specifically includes MT7621?
> What is the affected SoC then?
Thanks for falling into one of the issues that makes reviewing these
patches difficult. :/
> > - if (priv->id == ID_MT7621)
> > + if (priv->id == ID_MT7530 || priv->id == ID_MT7621)
> > mt7530_rmw(priv, MT7530_MFC, CPU_MASK, CPU_EN | CPU_PORT(port));
I *think* what the commit message should be saying is that the setup
for the CPU port(*) is necessary not only for MT7621, but also for
MT7530 variants as well.
That can be construed from the commit message, but it doesn't easily
read that way.
* - in this case, it's the CPU port field and the CPU enable bit.
Note that CPU_MASK only covers CPU_PORT() and not CPU_EN, but this
doesn't matter for mt7530_rmw().
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-06-16 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 2:53 [PATCH net v5 0/6] net: dsa: mt7530: fix multiple CPU ports, BPDU and LLDP handling arinc9.unal
2023-06-16 2:53 ` [PATCH net v5 1/6] net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP arinc9.unal
2023-06-16 10:01 ` Vladimir Oltean
2023-06-16 10:07 ` Russell King (Oracle)
2023-06-16 2:53 ` [PATCH net v5 2/6] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch arinc9.unal
2023-06-16 10:03 ` Vladimir Oltean
2023-06-16 10:17 ` Russell King (Oracle) [this message]
2023-06-16 10:25 ` Vladimir Oltean
2023-06-16 10:29 ` Vladimir Oltean
2023-06-16 10:37 ` Vladimir Oltean
2023-06-16 2:53 ` [PATCH net v5 3/6] net: dsa: mt7530: fix handling of BPDUs on " arinc9.unal
2023-06-16 10:11 ` Vladimir Oltean
2023-06-16 10:19 ` Russell King (Oracle)
2023-06-16 2:53 ` [PATCH net v5 4/6] net: dsa: mt7530: fix handling of LLDP frames arinc9.unal
2023-06-16 5:44 ` Frank Wunderlich
2023-06-16 6:21 ` Arınç ÜNAL
2023-06-16 8:59 ` Vladimir Oltean
2023-06-16 2:53 ` [PATCH net v5 5/6] net: dsa: introduce preferred_default_local_cpu_port and use on MT7530 arinc9.unal
2023-06-16 2:53 ` [PATCH net v5 6/6] MAINTAINERS: add me as maintainer of MEDIATEK SWITCH DRIVER arinc9.unal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIw20jmqI1d/W+YY@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=arinc.unal@arinc9$(echo .)com \
--cc=arinc9.unal@gmail$(echo .)com \
--cc=bartel.eerdekens@constell8$(echo .)be \
--cc=daniel@makrotopia$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=erkin.bozoglu@xeront$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=frank-w@public-files$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mithat.guner@xeront$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox