Subject: Re: [PATCH net v6 3/6] net: dsa: mt7530: fix handling of BPDUs on MT7530 switch

From: "Russell King (Oracle)" <[email-masked]>
Date: Mon, 19 Jun 2023 13:12:30 +0100

On Sat, Jun 17, 2023 at 09:26:46AM +0300, [email-masked] wrote:
> From: Arınç ÜNAL <[email-masked]>
> 
> BPDUs are link-local frames, therefore they must be trapped to the CPU
> port. Currently, the MT7530 switch treats BPDUs as regular multicast
> frames, therefore flooding them to user ports. To fix this, set BPDUs to be
> trapped to the CPU port. Group this on mt7530_setup() and
> mt7531_setup_common() into mt753x_trap_frames() and call that.
> 
> Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
> Signed-off-by: Arınç ÜNAL <[email-masked]>

Reviewed-by: Russell King (Oracle) <[email-masked]>

Thanks!

> +static void
> +mt753x_trap_frames(struct mt7530_priv *priv)

The only niggle is that it's not necessary to split this line, but as
other functions do this, it's better to follow the already established
convention in the file.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!