From: Simon Horman <simon.horman@corigine•com>
To: Choong Yong Liang <yong.liang.choong@linux•intel.com>
Cc: "Rajneesh Bhardwaj" <irenic.rajneesh@gmail•com>,
"David E Box" <david.e.box@intel•com>,
"Hans de Goede" <hdegoede@redhat•com>,
"Mark Gross" <markgross@kernel•org>,
"Jose Abreu" <Jose.Abreu@synopsys•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"David S . Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Marek Behún" <kabel@kernel•org>,
"Jean Delvare" <jdelvare@suse•com>,
"Guenter Roeck" <linux@roeck-us•net>,
"Giuseppe Cavallaro" <peppe.cavallaro@st•com>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Jose Abreu" <joabreu@synopsys•com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Richard Cochran" <richardcochran@gmail•com>,
"Philipp Zabel" <p.zabel@pengutronix•de>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
"Wong Vee Khee" <veekhee@apple•com>,
"Jon Hunter" <jonathanh@nvidia•com>,
"Jesse Brandeburg" <jesse.brandeburg@intel•com>,
"Revanth Kumar Uppala" <ruppala@nvidia•com>,
"Shenwei Wang" <shenwei.wang@nxp•com>,
"Andrey Konovalov" <andrey.konovalov@linaro•org>,
"Jochen Henneberg" <jh@henneberg-systemdesign•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
platform-driver-x86@vger•kernel.org, linux-hwmon@vger•kernel.org,
bpf@vger•kernel.org, "Voon Wei Feng" <weifeng.voon@intel•com>,
Tan@web•codeaurora.org, "Tee Min" <tee.min.tan@linux•intel.com>,
"Michael Sit Wei Hong" <michael.wei.hong.sit@intel•com>,
"Lai Peter Jun Ann" <jun.ann.lai@intel•com>
Subject: Re: [PATCH net-next 3/6] net: phy: update in-band AN mode when changing interface by PHY driver
Date: Thu, 22 Jun 2023 16:43:51 +0200 [thread overview]
Message-ID: <ZJReJ2yxqKGQx1BU@corigine.com> (raw)
In-Reply-To: <20230622041905.629430-4-yong.liang.choong@linux.intel.com>
On Thu, Jun 22, 2023 at 12:19:02PM +0800, Choong Yong Liang wrote:
> From: "Tan, Tee Min" <tee.min.tan@linux•intel.com>
>
> Add cur_link_an_mode into phy_device struct for PHY drivers to
> communicate the in-band AN mode setting with phylink framework.
>
> As there is a mechanism in PHY drivers to switch the PHY interface
> between SGMII and 2500BaseX according to link speed. In this case,
> the in-band AN mode should be switching based on the PHY interface
> as well, if the PHY interface has been changed/updated by PHY driver.
>
> For e.g., disable in-band AN in 2500BaseX mode, or enable in-band AN
> back for SGMII mode (10/100/1000Mbps).
>
> Signed-off-by: Tan, Tee Min <tee.min.tan@linux•intel.com>
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux•intel.com>
...
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 11c1e91563d4..c685b526e307 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -756,6 +756,8 @@ struct phy_device {
> /* MACsec management functions */
> const struct macsec_ops *macsec_ops;
> #endif
> + /* For communicate the AN mode setting with phylink framework. */
> + u8 cur_link_an_mode;
> };
Hi Choong Yong Liang,
Please consider adding cur_link_an_mode to the kernel doc
for struct phy_device - which is above the definition of struct phy_device.
next prev parent reply other threads:[~2023-06-22 14:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 4:18 [PATCH net-next 0/6] TSN auto negotiation between 1G and 2.5G Choong Yong Liang
2023-06-22 4:19 ` [PATCH net-next 1/6] platform/x86: intel_pmc_core: Add IPC mailbox accessor function and add SoC register access Choong Yong Liang
2023-06-22 8:18 ` Hans de Goede
2023-06-23 5:52 ` Choong Yong Liang
2023-06-23 12:44 ` Wong Vee Khee
2023-06-22 14:41 ` Simon Horman
2023-06-23 5:54 ` Choong Yong Liang
2023-06-22 4:19 ` [PATCH net-next 2/6] net: pcs: xpcs: combine C37 SGMII AN and 2500BASEX for Intel mGbE controller Choong Yong Liang
2023-06-22 4:19 ` [PATCH net-next 3/6] net: phy: update in-band AN mode when changing interface by PHY driver Choong Yong Liang
2023-06-22 14:43 ` Simon Horman [this message]
2023-06-22 15:06 ` Russell King (Oracle)
2023-06-23 5:35 ` Simon Horman
2023-06-23 6:02 ` Choong Yong Liang
2023-06-23 5:57 ` Choong Yong Liang
2023-06-22 4:19 ` [PATCH net-next 4/6] net: stmmac: enable Intel mGbE 1G/2.5G auto-negotiation support Choong Yong Liang
2023-06-22 4:19 ` [PATCH net-next 5/6] stmmac: intel: Separate driver_data of ADL-N from TGL Choong Yong Liang
2023-06-22 4:19 ` [PATCH net-next 6/6] net: stmmac: Add 1G/2.5G auto-negotiation support for ADL-N Choong Yong Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJReJ2yxqKGQx1BU@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=Jose.Abreu@synopsys$(echo .)com \
--cc=Tan@web$(echo .)codeaurora.org \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew@lunn$(echo .)ch \
--cc=andrey.konovalov@linaro$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david.e.box@intel$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hdegoede@redhat$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=irenic.rajneesh@gmail$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jh@henneberg-systemdesign$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=jun.ann.lai@intel$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@roeck-us$(echo .)net \
--cc=markgross@kernel$(echo .)org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=michael.wei.hong.sit@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=richardcochran@gmail$(echo .)com \
--cc=ruppala@nvidia$(echo .)com \
--cc=shenwei.wang@nxp$(echo .)com \
--cc=tee.min.tan@linux$(echo .)intel.com \
--cc=veekhee@apple$(echo .)com \
--cc=weifeng.voon@intel$(echo .)com \
--cc=yong.liang.choong@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox