From: Pablo Neira Ayuso <pablo@netfilter•org>
To: Randy Dunlap <rdunlap@infradead•org>
Cc: netdev@vger•kernel.org, Florian Westphal <fw@strlen•de>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Subject: Re: [PATCH net-next] linux/netfilter.h: fix kernel-doc warnings
Date: Mon, 26 Jun 2023 17:17:40 +0200 [thread overview]
Message-ID: <ZJmsFCv3CjVmXsWr@calendula> (raw)
In-Reply-To: <20230623061101.32513-1-rdunlap@infradead.org>
On Thu, Jun 22, 2023 at 11:11:01PM -0700, Randy Dunlap wrote:
> kernel-doc does not support DECLARE_PER_CPU(), so don't mark it with
> kernel-doc notation.
>
> One comment block is not kernel-doc notation, so just use
> "/*" to begin the comment.
>
> Quietens these warnings:
>
> netfilter.h:493: warning: Function parameter or member 'bool' not described in 'DECLARE_PER_CPU'
> netfilter.h:493: warning: Function parameter or member 'nf_skb_duplicated' not described in 'DECLARE_PER_CPU'
> netfilter.h:493: warning: expecting prototype for nf_skb_duplicated(). Prototype was for DECLARE_PER_CPU() instead
> netfilter.h:496: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Contains bitmask of ctnetlink event subscribers, if any.
Applied to nf.git, thanks
prev parent reply other threads:[~2023-06-26 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 6:11 [PATCH net-next] linux/netfilter.h: fix kernel-doc warnings Randy Dunlap
2023-06-23 7:18 ` Simon Horman
2023-06-26 15:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJmsFCv3CjVmXsWr@calendula \
--to=pablo@netfilter$(echo .)org \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=kadlec@netfilter$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox