From: Baoquan He <bhe@redhat•com>
To: Simon Horman <simon.horman@corigine•com>
Cc: linux-kernel@vger•kernel.org, akpm@linux-foundation•org,
linux-mm@kvack•org, schnelle@linux•ibm.com, vkoul@kernel•org,
eli.billauer@gmail•com, arnd@arndb•de,
gregkh@linuxfoundation•org, derek.kiernan@amd•com,
dragan.cvetic@amd•com, linux@dominikbrodowski•net,
Jonathan.Cameron@huawei•com, linus.walleij@linaro•org,
tsbogend@alpha•franken.de, joyce.ooi@intel•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, tglx@linutronix•de, maz@kernel•org,
mturquette@baylibre•com, sboyd@kernel•org, robh+dt@kernel•org,
frowand.list@gmail•com, kernel test robot <lkp@intel•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM
Date: Wed, 12 Jul 2023 08:46:13 +0800 [thread overview]
Message-ID: <ZK331Ru27wiRApF2@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZK2Ok5i2m7zS6Uq0@corigine.com>
On 07/11/23 at 06:17pm, Simon Horman wrote:
> On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote:
> > On s390 systems (aka mainframes), it has classic channel devices for
> > networking and permanent storage that are currently even more common
> > than PCI devices. Hence it could have a fully functional s390 kernel
> > with CONFIG_PCI=n, then the relevant iomem mapping functions
> > [including ioremap(), devm_ioremap(), etc.] are not available.
> >
> > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built
> > to cause below compiling error if PCI is unset:
> >
> > ------
> > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined!
> > ------
> >
> > Reported-by: kernel test robot <lkp@intel•com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/
> > Signed-off-by: Baoquan He <bhe@redhat•com>
>
>
> Reviewed-by: Simon Horman <simon.horman@corigine•com>
> Tested-by: Simon Horman <simon.horman@corigine•com> # build-tested
Thanks, Simon.
>
> I wonder if this should also have:
>
> Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig")
Agree, it's worth having Fixes tag.
prev parent reply other threads:[~2023-07-12 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230707135852.24292-1-bhe@redhat.com>
2023-07-07 13:58 ` [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Baoquan He
2023-07-11 17:17 ` Simon Horman
2023-07-12 0:46 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK331Ru27wiRApF2@MiWiFi-R3L-srv \
--to=bhe@redhat$(echo .)com \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=derek.kiernan@amd$(echo .)com \
--cc=dragan.cvetic@amd$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eli.billauer@gmail$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=joyce.ooi@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux@dominikbrodowski$(echo .)net \
--cc=lkp@intel$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mturquette@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=simon.horman@corigine$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vkoul@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox