From: Ido Schimmel <idosch@nvidia•com>
To: Dan Carpenter <dan.carpenter@linaro•org>
Cc: Petr Machata <petrm@nvidia•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Danielle Ratson <danieller@nvidia•com>,
netdev@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: Re: [PATCH net] mlxsw: spectrum_router: Fix an IS_ERR() vs NULL check
Date: Mon, 3 Jul 2023 20:06:40 +0300 [thread overview]
Message-ID: <ZKMAIGKBsFZ9v114@shredder> (raw)
In-Reply-To: <16334acc-dc95-45be-bc12-53b2a60d9a59@moroto.mountain>
On Mon, Jul 03, 2023 at 06:24:52PM +0300, Dan Carpenter wrote:
> The mlxsw_sp_crif_alloc() function returns NULL on error. It doesn't
> return error pointers. Fix the check.
>
> Fixes: 78126cfd5dc9 ("mlxsw: spectrum_router: Maintain CRIF for fallback loopback RIF")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro•org>
Reviewed-by: Ido Schimmel <idosch@nvidia•com>
next prev parent reply other threads:[~2023-07-03 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:24 [PATCH net] mlxsw: spectrum_router: Fix an IS_ERR() vs NULL check Dan Carpenter
2023-07-03 15:41 ` Alexander Lobakin
2023-07-03 17:06 ` Ido Schimmel [this message]
2023-07-04 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKMAIGKBsFZ9v114@shredder \
--to=idosch@nvidia$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox