Subject: Re: [PATCH iwl-next v1] i40e: Clear stats after deleting tc

From: Simon Horman <[email-masked]>
Date: Tue, 25 Jul 2023 14:25:02 +0200

On Mon, Jul 24, 2023 at 11:43:19AM +0200, Jedrzej Jagielski wrote:
> From: Grzegorz Szczurek <[email-masked]>
> 
> There was an issue with ethtool stats that
> have not been cleared after tc had been deleted.

I think it would be good to elaborate on what the issue is,
perhaps with an example. I think this should be added to
the patch description.

> Fix this by resetting stats after deleting tc
> by calling i40e_vsi_reset_stats() function after
> distroying qdisc.
> 
> Signed-off-by: Grzegorz Szczurek <[email-masked]>
> Signed-off-by: Jedrzej Jagielski <[email-masked]>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 29ad1797adce..6f604bfe7437 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -5885,6 +5885,11 @@ static int i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 enabled_tc)
>  
>  	/* Update the netdev TC setup */
>  	i40e_vsi_config_netdev_tc(vsi, enabled_tc);
> +
> +	/* After distroying qdisc reset all stats of the vsi */

nit: distroying -> destroying

> +	if (!vsi->mqprio_qopt.qopt.hw)
> +		i40e_vsi_reset_stats(vsi);
> +
>  out:
>  	return ret;
>  }

-- 
pw-bot: changes-requested