From: Ido Schimmel <idosch@idosch•org>
To: Ratheesh Kannoth <rkannoth@marvell•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com
Subject: Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors
Date: Tue, 25 Jul 2023 13:12:46 +0300 [thread overview]
Message-ID: <ZL+gHkLnLE91YBkS@shredder> (raw)
In-Reply-To: <20230725032451.505189-1-rkannoth@marvell.com>
On Tue, Jul 25, 2023 at 08:54:51AM +0530, Ratheesh Kannoth wrote:
> Support for dissecting IPSEC field SPI (which is
> 32bits in size) for ESP and AH packets.
>
> This implementation does not support NAT-T
> (encapsulation of ESP packets over UDP).
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell•com>
> ---
> include/net/flow_dissector.h | 9 ++++++
> include/net/flow_offload.h | 6 ++++
> include/uapi/linux/pkt_cls.h | 3 ++
> net/core/flow_dissector.c | 53 +++++++++++++++++++++++++++++++++++-
> net/core/flow_offload.c | 7 +++++
> net/sched/cls_flower.c | 18 ++++++++++++
Please split flow dissector and flower changes into separate patches.
Also, you can't add the flow offload bits without a corresponding driver
change. Nobody calls the exported flow_rule_match_ipsec() function.
[...]
> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> index 7865f5a9885b..a90b0e3d351f 100644
> --- a/include/uapi/linux/pkt_cls.h
> +++ b/include/uapi/linux/pkt_cls.h
> @@ -594,6 +594,9 @@ enum {
>
> TCA_FLOWER_KEY_L2TPV3_SID, /* be32 */
>
> + TCA_FLOWER_KEY_SPI, /* be32 */
> + TCA_FLOWER_KEY_SPI_MASK, /* be32 */
> +
This will break existing user space on new kernels. New attributes must
be added at the end.
> TCA_FLOWER_L2_MISS, /* u8 */
>
> TCA_FLOWER_KEY_CFM, /* nested */
next prev parent reply other threads:[~2023-07-25 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 3:24 [PATCH net-next] flow_dissector: Add IPSEC dissectors Ratheesh Kannoth
2023-07-25 5:11 ` Leon Romanovsky
2023-07-26 5:52 ` Ratheesh Kannoth
2023-07-25 10:12 ` Ido Schimmel [this message]
2023-07-26 5:54 ` Ratheesh Kannoth
2023-07-25 19:50 ` Simon Horman
2023-07-26 6:34 ` Ratheesh Kannoth
2023-07-26 7:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL+gHkLnLE91YBkS@shredder \
--to=idosch@idosch$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox