From: Simon Horman <simon.horman@corigine•com>
To: Dmitry Safonov <dima@arista•com>
Cc: David Ahern <dsahern@kernel•org>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org,
Andy Lutomirski <luto@amacapital•net>,
Ard Biesheuvel <ardb@kernel•org>,
Bob Gilligan <gilligan@arista•com>,
Dan Carpenter <error27@gmail•com>,
David Laight <David.Laight@aculab•com>,
Dmitry Safonov <0x7f454c46@gmail•com>,
Donald Cassidy <dcassidy@redhat•com>,
Eric Biggers <ebiggers@kernel•org>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Francesco Ruggeri <fruggeri05@gmail•com>,
"Gaillardetz, Dominik" <dgaillar@ciena•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Ivan Delalande <colona@arista•com>,
Leonard Crestez <cdleonard@gmail•com>,
Salam Noureddine <noureddine@arista•com>,
"Tetreault, Francois" <ftetreau@ciena•com>,
netdev@vger•kernel.org,
Steen Hegelund <Steen.Hegelund@microchip•com>
Subject: Re: [PATCH v8.1 net-next 01/23] net/tcp: Prepare tcp_md5sig_pool for TCP-AO
Date: Mon, 24 Jul 2023 15:11:52 +0200 [thread overview]
Message-ID: <ZL54mOdTzX5Z9Fji@corigine.com> (raw)
In-Reply-To: <20230721161916.542667-2-dima@arista.com>
On Fri, Jul 21, 2023 at 05:18:52PM +0100, Dmitry Safonov wrote:
Hi Dmitry,
some minor nits from my side.
...
> +/**
> + * tcp_sigpool_start - disable bh and start using tcp_sigpool_ahash
> + * @id: tcp_sigpool that was previously allocated by tcp_sigpool_alloc_ahash()
> + * @c: returned tcp_sigpool for usage (uninitialized on failure)
> + */
> +int tcp_sigpool_start(unsigned int id, struct tcp_sigpool *c);
> +/**
> + * tcp_sigpool_end - enable bh and stop using tcp_sigpool
nit: as this is a kernel doc, please document @c here.
> + */
> +void tcp_sigpool_end(struct tcp_sigpool *c);
> +size_t tcp_sigpool_algo(unsigned int id, char *buf, size_t buf_len);
> /* - functions */
> int tcp_v4_md5_hash_skb(char *md5_hash, const struct tcp_md5sig_key *key,
> const struct sock *sk, const struct sk_buff *skb);
...
> @@ -1439,8 +1443,7 @@ int tcp_v4_md5_hash_skb(char *md5_hash, const struct tcp_md5sig_key *key,
> const struct sock *sk,
> const struct sk_buff *skb)
> {
> - struct tcp_md5sig_pool *hp;
> - struct ahash_request *req;
> + struct tcp_sigpool hp;
> const struct tcphdr *th = tcp_hdr(skb);
> __be32 saddr, daddr;
nit: please consider using reverse xmas tree - longest line to shortest -
for these local variable declarations.
const struct tcphdr *th = tcp_hdr(skb);
struct tcp_sigpool hp;
__be32 saddr, daddr;
Likewise, elsewhere, when it can be done without excess churn.
...
next prev parent reply other threads:[~2023-07-24 13:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 16:18 [PATCH v8.1 net-next 00/23] net/tcp: Add TCP-AO support Dmitry Safonov
2023-07-21 16:18 ` [PATCH v8.1 net-next 01/23] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Dmitry Safonov
2023-07-24 13:11 ` Simon Horman [this message]
2023-07-24 16:06 ` Dmitry Safonov
2023-07-24 19:46 ` Simon Horman
2023-07-21 16:18 ` [PATCH v8.1 net-next 02/23] net/tcp: Add TCP-AO config and structures Dmitry Safonov
2023-07-21 16:18 ` [PATCH v8.1 net-next 03/23] net/tcp: Introduce TCP_AO setsockopt()s Dmitry Safonov
2023-07-24 19:31 ` Simon Horman
2023-07-25 20:16 ` Dmitry Safonov
2023-07-26 7:56 ` Simon Horman
2023-07-21 16:18 ` [PATCH v8.1 net-next 04/23] net/tcp: Prevent TCP-MD5 with TCP-AO being set Dmitry Safonov
2023-07-21 16:18 ` [PATCH v8.1 net-next 05/23] net/tcp: Calculate TCP-AO traffic keys Dmitry Safonov
2023-07-21 16:18 ` [PATCH v8.1 net-next 06/23] net/tcp: Add TCP-AO sign to outgoing packets Dmitry Safonov
2023-07-25 17:02 ` Simon Horman
2023-07-25 19:10 ` Dmitry Safonov
2023-07-25 20:23 ` Simon Horman
2023-07-21 16:18 ` [PATCH v8.1 net-next 07/23] net/tcp: Add tcp_parse_auth_options() Dmitry Safonov
2023-07-21 16:18 ` [PATCH v8.1 net-next 08/23] net/tcp: Add AO sign to RST packets Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 09/23] net/tcp: Add TCP-AO sign to twsk Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 10/23] net/tcp: Wire TCP-AO to request sockets Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 11/23] net/tcp: Sign SYN-ACK segments with TCP-AO Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 12/23] net/tcp: Verify inbound TCP-AO signed segments Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 13/23] net/tcp: Add TCP-AO segments counters Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 14/23] net/tcp: Add TCP-AO SNE support Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 15/23] net/tcp: Add tcp_hash_fail() ratelimited logs Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 17/23] net/tcp: Add option for TCP-AO to (not) hash header Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 18/23] net/tcp: Add TCP-AO getsockopt()s Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 19/23] net/tcp: Allow asynchronous delete for TCP-AO keys (MKTs) Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 20/23] net/tcp: Add static_key for TCP-AO Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 21/23] net/tcp: Wire up l3index to TCP-AO Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 22/23] net/tcp: Add TCP_AO_REPAIR Dmitry Safonov
2023-07-21 16:19 ` [PATCH v8.1 net-next 23/23] Documentation/tcp: Add TCP-AO documentation Dmitry Safonov
2023-07-21 18:12 ` [PATCH v8.1 net-next 00/23] net/tcp: Add TCP-AO support David Ahern
2023-07-21 18:18 ` Eric Dumazet
2023-07-21 19:33 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL54mOdTzX5Z9Fji@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=0x7f454c46@gmail$(echo .)com \
--cc=David.Laight@aculab$(echo .)com \
--cc=Steen.Hegelund@microchip$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=cdleonard@gmail$(echo .)com \
--cc=colona@arista$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dcassidy@redhat$(echo .)com \
--cc=dgaillar@ciena$(echo .)com \
--cc=dima@arista$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=ebiggers@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=error27@gmail$(echo .)com \
--cc=fruggeri05@gmail$(echo .)com \
--cc=ftetreau@ciena$(echo .)com \
--cc=gilligan@arista$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=noureddine@arista$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox