Subject: Re: [PATCH v12 03/26] net/ethtool: add ULP_DDP_{GET,SET} operations for caps and stats

From: Simon Horman <[email-masked]>
Date: Sat, 15 Jul 2023 11:14:21 +0100

On Wed, Jul 12, 2023 at 04:14:50PM +0000, Aurelien Aptel wrote:

...

> diff --git a/net/ethtool/ulp_ddp.c b/net/ethtool/ulp_ddp.c
> new file mode 100644
> index 000000000000..e5451689fef9
> --- /dev/null
> +++ b/net/ethtool/ulp_ddp.c

...

> +static int ulp_ddp_put_stats64(struct sk_buff *skb, int attrtype, const u64 *val,
> +			       unsigned int count)
> +{
> +	struct nlattr *nest;
> +	unsigned int i, attr;

nit: please use reverse xmas tree - longest line to shortest -
     for local variable declarations in Networking code.