Subject: Re: [PATCHv2 net 2/2] team: reset team's flags when down link is P2P device

From: Hangbin Liu <[email-masked]>
Date: Tue, 18 Jul 2023 17:10:56 +0800

On Tue, Jul 18, 2023 at 10:01:27AM +0200, Paolo Abeni wrote:
> > diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> > index 555b0b1e9a78..9104e373c8cb 100644
> > --- a/drivers/net/team/team.c
> > +++ b/drivers/net/team/team.c
> > @@ -2135,6 +2135,11 @@ static void team_setup_by_port(struct net_device *dev,
> >  	dev->mtu = port_dev->mtu;
> >  	memcpy(dev->broadcast, port_dev->broadcast, port_dev->addr_len);
> >  	eth_hw_addr_inherit(dev, port_dev);
> > +
> > +	if (port_dev->flags & IFF_POINTOPOINT) {
> > +		dev->flags &= ~(IFF_BROADCAST | IFF_MULTICAST);
> > +		dev->flags |= (IFF_POINTOPOINT | IFF_NOARP);
> > +	}
> 
> It's unclear to me what happens with the following sequence of events:
> 
> * p2p dev is enslaved to team (IFF_BROADCAST cleared)
> * p2p dev is removed from team
> * plain ether device is enslaved to team.
> 
> I don't see where/when IFF_BROADCAST is set again. Could you please
> point it out?

Hmm, you are right. Bonding will call bond_ether_setup(), ether_setup() to
reset the dev flags. But team didn't do that. I will fix it.

Thanks
Hangbin