Subject: Re: [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page tracking

From: Simon Horman <[email-masked]>
Date: Tue, 25 Jul 2023 19:29:53 +0200

On Wed, Jul 19, 2023 at 03:35:25PM -0700, Brett Creeley wrote:

...

> +static void pds_vfio_dirty_free_bitmaps(struct pds_vfio_dirty *dirty)
> +{
> +	if (dirty->host_seq.bmp)
> +		vfree(dirty->host_seq.bmp);
> +	if (dirty->host_ack.bmp)
> +		vfree(dirty->host_ack.bmp);

Hi Brett,

I don't think there is a need to guard these vfree calls,
as I think they will be no-ops with NULL arguments.

> +
> +	dirty->host_seq.bmp = NULL;
> +	dirty->host_ack.bmp = NULL;
> +}

...