From: Simon Horman <simon.horman@corigine•com>
To: Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, netdev@vger•kernel.org,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel•com>,
sasha.neftin@intel•com,
Alejandra Victoria Alcaraz <alejandra.victoria.alcaraz@intel•com>,
Naama Meir <naamax.meir@linux•intel.com>
Subject: Re: [PATCH net] igc: Fix Kernel Panic during ndo_tx_timeout callback
Date: Wed, 26 Jul 2023 10:07:56 +0200 [thread overview]
Message-ID: <ZMDUXFWXOVuQyzSx@corigine.com> (raw)
In-Reply-To: <20230724161250.2177321-1-anthony.l.nguyen@intel.com>
On Mon, Jul 24, 2023 at 09:12:50AM -0700, Tony Nguyen wrote:
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel•com>
>
> The Xeon validation group has been carrying out some loaded tests
> with various HW configurations, and they have seen some transmit
> queue time out happening during the test. This will cause the
> reset adapter function to be called by igc_tx_timeout().
> Similar race conditions may arise when the interface is being brought
> down and up in igc_reinit_locked(), an interrupt being generated, and
> igc_clean_tx_irq() being called to complete the TX.
>
> When the igc_tx_timeout() function is invoked, this patch will turn
> off all TX ring HW queues during igc_down() process. TX ring HW queues
> will be activated again during the igc_configure_tx_ring() process
> when performing the igc_up() procedure later.
>
> This patch also moved existing igc_disable_tx_ring_hw() to avoid using
> forward declaration.
...
> Fixes: 9b275176270e ("igc: Add ndo_tx_timeout support")
> Tested-by: Alejandra Victoria Alcaraz <alejandra.victoria.alcaraz@intel•com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel•com>
> Acked-by: Sasha Neftin <sasha.neftin@intel•com>
> Tested-by: Naama Meir <naamax.meir@linux•intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
...
next prev parent reply other threads:[~2023-07-26 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 16:12 [PATCH net] igc: Fix Kernel Panic during ndo_tx_timeout callback Tony Nguyen
2023-07-26 8:07 ` Simon Horman [this message]
2023-07-26 9:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMDUXFWXOVuQyzSx@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=alejandra.victoria.alcaraz@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=muhammad.husaini.zulkifli@intel$(echo .)com \
--cc=naamax.meir@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sasha.neftin@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox