From: Simon Horman <simon.horman@corigine•com>
To: Christian Marangi <ansuelsmth@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Atin Bainada <hi@atinb•me>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone
Date: Wed, 26 Jul 2023 10:19:34 +0200 [thread overview]
Message-ID: <ZMDXFiSFI/hyr8j6@corigine.com> (raw)
In-Reply-To: <20230724033058.16795-2-ansuelsmth@gmail.com>
On Mon, Jul 24, 2023 at 05:30:57AM +0200, Christian Marangi wrote:
> Address learning should initially be turned off by the driver for port
> operation in standalone mode, then the DSA core handles changes to it
> via ds->ops->port_bridge_flags().
>
> Currently this is not the case for qca8k where learning is enabled
> unconditionally in qca8k_setup for every user port.
>
> Handle ports configured in standalone mode by making the learning
> configurable and not enabling it by default.
>
> Implement .port_pre_bridge_flags and .port_bridge_flags dsa ops to
> enable learning for bridge that request it and tweak
> .port_stp_state_set to correctly disable learning when port is
> configured in standalone mode.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail•com>
> diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
...
> @@ -1978,6 +1977,8 @@ static const struct dsa_switch_ops qca8k_switch_ops = {
> .port_change_mtu = qca8k_port_change_mtu,
> .port_max_mtu = qca8k_port_max_mtu,
> .port_stp_state_set = qca8k_port_stp_state_set,
> + .port_pre_bridge_flags = qca8k_port_pre_bridge_flags,
> + .port_bridge_flags = qca8k_port_bridge_flags,
> .port_bridge_join = qca8k_port_bridge_join,
> .port_bridge_leave = qca8k_port_bridge_leave,
> .port_fast_age = qca8k_port_fast_age,
> diff --git a/drivers/net/dsa/qca/qca8k-common.c b/drivers/net/dsa/qca/qca8k-common.c
...
> @@ -591,6 +611,30 @@ void qca8k_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)
>
> qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(port),
> QCA8K_PORT_LOOKUP_STATE_MASK, stp_state);
> +
> + qca8k_port_configure_learning(ds, port, learning);
> +}
> +
> +int qca8k_port_pre_bridge_flags(struct dsa_switch *ds, int port,
> + struct switchdev_brport_flags flags,
> + struct netlink_ext_ack *extack)
> +{
> + if (flags.mask & ~BR_LEARNING)
> + return -EINVAL;
If I am reading things right then some implementation of this callback
return -EINVAL when they see unexpected flags. And some seem not to
- possibly because all flags are expected.
So I'm slightly unsure if this is correct or not.
> +
> + return 0;
> +}
...
next prev parent reply other threads:[~2023-07-26 8:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 3:30 [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Christian Marangi
2023-07-24 3:30 ` [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone Christian Marangi
2023-07-26 8:19 ` Simon Horman [this message]
2023-07-26 12:14 ` Vladimir Oltean
2023-07-26 13:15 ` Simon Horman
2023-07-26 12:12 ` Vladimir Oltean
2023-07-27 19:05 ` Christian Marangi
2023-07-26 22:22 ` Florian Fainelli
2023-07-24 3:30 ` [net-next PATCH 3/3] net: dsa: qca8k: limit user ports access to the first CPU port on setup Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 13:18 ` Vladimir Oltean
2023-07-27 19:10 ` Christian Marangi
2023-07-27 21:14 ` Vladimir Oltean
2023-07-26 22:21 ` Florian Fainelli
2023-07-27 21:16 ` Vladimir Oltean
2023-07-26 8:17 ` [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Simon Horman
2023-07-26 12:06 ` Vladimir Oltean
2023-07-26 22:19 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMDXFiSFI/hyr8j6@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hi@atinb$(echo .)me \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox