From: Simon Horman <simon.horman@corigine•com>
To: Donald Hunter <donald.hunter@gmail•com>
Cc: netdev@vger•kernel.org, Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
donald.hunter@redhat•com
Subject: Re: [PATCH net-next v1 0/3] tools/net/ynl: Add support for netlink-raw families
Date: Wed, 26 Jul 2023 14:38:29 +0200 [thread overview]
Message-ID: <ZMETxe6sXMRvJZ/3@corigine.com> (raw)
In-Reply-To: <20230725162205.27526-1-donald.hunter@gmail.com>
On Tue, Jul 25, 2023 at 05:22:02PM +0100, Donald Hunter wrote:
> This patchset adds support for netlink-raw families such as rtnetlink.
>
> The first patch contains the schema definition.
> The second patch extends ynl to support netlink-raw
> The third patch adds rtnetlink addr and route message types
>
> The second patch depends on "tools: ynl-gen: fix parse multi-attr enum
> attribute":
>
> https://patchwork.kernel.org/project/netdevbpf/list/?series=769229
>
> The netlink-raw schema is very similar to genetlink-legacy and I thought
> about making the changes there and symlinking to it. On balance I
> thought that might be problematic for accurate schema validation.
>
> rtnetlink doesn't seem to fit into unified or directional message
> enumeration models. It seems like an 'explicit' model would be useful,
> to require the schema author to specify the message ids directly. The
> patch supports commands and it supports notifications, but it's
> currently hard to support both simultaneously from the same netlink-raw
> spec. I plan to work on this in a future patchset.
>
> There is not yet support for notifications because ynl currently doesn't
> support defining 'event' properties on a 'do' operation. I plan to work
> on this in a future patch.
>
> The link message types are a work in progress that I plan to submit in a
> future patchset. Links contain different nested attributes dependent on
> the type of link. Decoding these will need some kind of attr-space
> selection based on the value of another attribute in the message.
>
> Donald Hunter (3):
> doc/netlink: Add a schema for netlink-raw families
> tools/net/ynl: Add support for netlink-raw families
> doc/netlink: Add specs for addr and route rtnetlink message types
Hi Donald,
unfortunately this series doesn't apply to current net-next.
Please consider rebasing and reposting.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-07-26 12:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 16:22 [PATCH net-next v1 0/3] tools/net/ynl: Add support for netlink-raw families Donald Hunter
2023-07-25 16:22 ` [PATCH net-next v1 1/3] doc/netlink: Add a schema " Donald Hunter
2023-07-26 21:09 ` Jakub Kicinski
2023-07-26 21:48 ` Donald Hunter
2023-07-26 22:03 ` Jakub Kicinski
2023-07-25 16:22 ` [PATCH net-next v1 2/3] tools/net/ynl: Add support " Donald Hunter
2023-07-26 21:37 ` Jakub Kicinski
2023-07-26 22:01 ` Donald Hunter
2023-07-26 22:23 ` Jakub Kicinski
2023-07-25 16:22 ` [PATCH net-next v1 3/3] doc/netlink: Add specs for addr and route rtnetlink message types Donald Hunter
2023-07-26 4:16 ` [PATCH net-next v1 0/3] tools/net/ynl: Add support for netlink-raw families Jakub Kicinski
2023-07-26 12:38 ` Simon Horman [this message]
2023-07-26 13:06 ` Donald Hunter
2023-07-26 13:16 ` Simon Horman
2023-07-26 15:55 ` Jakub Kicinski
2023-07-26 16:09 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMETxe6sXMRvJZ/3@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=donald.hunter@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox