From: Ido Schimmel <idosch@idosch•org>
To: Eric Dumazet <edumazet@google•com>
Cc: "David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, eric.dumazet@gmail•com,
syzbot <syzkaller@googlegroups•com>,
Zahari Doychev <zdoychev@maxlinear•com>,
Simon Horman <simon.horman@corigine•com>,
Ido Schimmel <idosch@nvidia•com>
Subject: Re: [PATCH v2 net] net: flower: fix stack-out-of-bounds in fl_set_key_cfm()
Date: Wed, 26 Jul 2023 20:09:05 +0300 [thread overview]
Message-ID: <ZMFTMW8pc168mabK@shredder> (raw)
In-Reply-To: <20230726145815.943910-1-edumazet@google.com>
On Wed, Jul 26, 2023 at 02:58:15PM +0000, Eric Dumazet wrote:
> Typical misuse of
>
> nla_parse_nested(array, XXX_MAX, ...);
>
> array must be declared as
>
> struct nlattr *array[XXX_MAX + 1];
>
> v2: Based on feedbacks from Ido Schimmel and Zahari Doychev,
> I also changed TCA_FLOWER_KEY_CFM_OPT_MAX and cfm_opt_policy
> definitions.
>
[...]
>
> Fixes: 7cfffd5fed3e ("net: flower: add support for matching cfm fields")
> Reported-by: syzbot <syzkaller@googlegroups•com>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Cc: Zahari Doychev <zdoychev@maxlinear•com>
> Cc: Simon Horman <simon.horman@corigine•com>
> Cc: Ido Schimmel <idosch@nvidia•com>
Reviewed-by: Ido Schimmel <idosch@nvidia•com>
Thanks
next prev parent reply other threads:[~2023-07-26 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 14:58 [PATCH v2 net] net: flower: fix stack-out-of-bounds in fl_set_key_cfm() Eric Dumazet
2023-07-26 17:09 ` Ido Schimmel [this message]
2023-07-27 6:38 ` Zahari Doychev
2023-07-28 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMFTMW8pc168mabK@shredder \
--to=idosch@idosch$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=syzkaller@googlegroups$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=zdoychev@maxlinear$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox