Subject: Re: [PATCH 1/1] qed: Fix scheduling in a tasklet while getting stats

From: Simon Horman <[email-masked]>
Date: Thu, 27 Jul 2023 13:59:10 +0200

On Wed, Jul 26, 2023 at 08:19:30PM +0300, Konstantin Khorenko wrote:

...

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iscsi.h b/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> index dec2b00259d4..7d8d6ad7faa9 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iscsi.h
> @@ -43,7 +43,8 @@ void qed_iscsi_free(struct qed_hwfn *p_hwfn);
>   * Return: Void.
>   */
>  void qed_get_protocol_stats_iscsi(struct qed_dev *cdev,
> -				  struct qed_mcp_iscsi_stats *stats);
> +				  struct qed_mcp_iscsi_stats *stats,
> +				  bool is_atomic);

Hi Konstantin,

Please add is_atomic to the kernel doc for qed_get_protocol_stats_iscsi,
which is immediately above this function declaration.

>  #else /* IS_ENABLED(CONFIG_QED_ISCSI) */
>  static inline int qed_iscsi_alloc(struct qed_hwfn *p_hwfn)
>  {
> @@ -56,7 +57,8 @@ static inline void qed_iscsi_free(struct qed_hwfn *p_hwfn) {}
>  
>  static inline void
>  qed_get_protocol_stats_iscsi(struct qed_dev *cdev,
> -			     struct qed_mcp_iscsi_stats *stats) {}
> +			     struct qed_mcp_iscsi_stats *stats,
> +			     bool is_atomic) {}
>  #endif /* IS_ENABLED(CONFIG_QED_ISCSI) */
>  
>  #endif

-- 
pw-bot: changes-requested