From: Simon Horman <horms@kernel•org>
To: Min-Hua Chen <minhuadotchen@gmail•com>
Cc: Trond Myklebust <trond.myklebust@hammerspace•com>,
Anna Schumaker <anna@kernel•org>,
Chuck Lever <chuck.lever@oracle•com>,
Jeff Layton <jlayton@kernel•org>, Neil Brown <neilb@suse•de>,
Olga Kornievskaia <kolga@netapp•com>,
Dai Ngo <Dai.Ngo@oracle•com>, Tom Talpey <tom@talpey•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
linux-nfs@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] sunrpc: wrap debug symobls with CONFIG_SUNRPC_DEBUG
Date: Sun, 30 Jul 2023 17:38:29 +0200 [thread overview]
Message-ID: <ZMaD9ZIxQ3kRuCgB@kernel.org> (raw)
In-Reply-To: <20230728145751.138057-1-minhuadotchen@gmail.com>
On Fri, Jul 28, 2023 at 10:57:50PM +0800, Min-Hua Chen wrote:
> rpc_debug, nfs_debug, nfsd_debug, and nlm_debug are used
> if CONFIG_SUNRPC_DEBUG is set. Wrap them with CONFIG_SUNRPC_DEBUG
> and fix the following sparse warnings:
>
> net/sunrpc/sysctl.c:29:17: sparse: warning: symbol 'rpc_debug' was not declared. Should it be static?
> net/sunrpc/sysctl.c:32:17: sparse: warning: symbol 'nfs_debug' was not declared. Should it be static?
> net/sunrpc/sysctl.c:35:17: sparse: warning: symbol 'nfsd_debug' was not declared. Should it be static?
> net/sunrpc/sysctl.c:38:17: sparse: warning: symbol 'nlm_debug' was not declared. Should it be static?
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail•com>
Reviewed-by: Simon Horman <horms@kernel•org>
prev parent reply other threads:[~2023-07-30 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:57 [PATCH] sunrpc: wrap debug symobls with CONFIG_SUNRPC_DEBUG Min-Hua Chen
2023-07-30 15:38 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMaD9ZIxQ3kRuCgB@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Dai.Ngo@oracle$(echo .)com \
--cc=anna@kernel$(echo .)org \
--cc=chuck.lever@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jlayton@kernel$(echo .)org \
--cc=kolga@netapp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=minhuadotchen@gmail$(echo .)com \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tom@talpey$(echo .)com \
--cc=trond.myklebust@hammerspace$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox