Subject: Re: [net-next PATCH v1 1/9] net: Introduce new fields for napi and queue associations

From: Simon Horman <[email-masked]>
Date: Sun, 30 Jul 2023 19:10:05 +0200

On Fri, Jul 28, 2023 at 05:46:56PM -0700, Amritha Nambiar wrote:

...

> diff --git a/net/core/dev.c b/net/core/dev.c
> index b58674774a57..875023ab614c 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6389,6 +6389,42 @@ int dev_set_threaded(struct net_device *dev, bool threaded)
>  }
>  EXPORT_SYMBOL(dev_set_threaded);
>  
> +/**
> + * netif_napi_add_queue - Associate queue with the napi
> + * @napi: NAPI context
> + * @queue_index: Index of queue
> + * @queue_type: queue type as RX or TX

Hi Arithma,

a minor nit from my side: @queue_type -> @type

> + *
> + * Add queue with its corresponding napi context
> + */
> +int netif_napi_add_queue(struct napi_struct *napi, unsigned int queue_index,
> +			 enum queue_type type)
> +{

...