Subject: Re: [patch net-next v2 00/11] devlink: use spec to generate split ops

From: Jiri Pirko <[email-masked]>
Date: Thu, 3 Aug 2023 08:01:34 +0200

Thu, Aug 03, 2023 at 04:07:34AM CEST, [email-masked] wrote:
>On Wed,  2 Aug 2023 17:20:12 +0200 Jiri Pirko wrote:
>> This is an outcome of the discussion in the following thread:
>> https://lore.kernel.org/netdev/[email-masked]/
>> It serves as a dependency on the linked selector patchset.
>> 
>> There is an existing spec for devlink used for userspace part
>> generation. There are two commands supported there.
>> 
>> This patchset extends the spec so kernel split ops code could
>> be generated from it.
>
>Looks good! But you need to reshuffle stuff in patches 7-10
>because there's a temporary build breakage. Some squashing,
>reordering and maybe splitting patch 10 should do?

I was very careful not to cause any breakage. Will double check, fix the
2 nits and send v3.

Thanks!

>
>Feel free to post v3 without waiting the full 24h.
>-- 
>pw-bot: cr