Subject: Re: [PATCH net-next 1/4] gve: Control path for DQO-QPL

From: Simon Horman <[email-masked]>
Date: Thu, 3 Aug 2023 11:28:33 +0200

On Wed, Aug 02, 2023 at 09:33:35PM +0000, Rushil Gupta wrote:

...

Hi Rashil,

> @@ -505,12 +524,24 @@ static int gve_adminq_create_tx_queue(struct gve_priv *priv, u32 queue_index)
>  
>  		cmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
>  	} else {
> +		u16 comp_ring_size = 0;
> +		u32 qpl_id = 0;
> +
> +		if (priv->queue_format == GVE_DQO_RDA_FORMAT) {
> +			qpl_id = GVE_RAW_ADDRESSING_QPL_ID;
> +			comp_ring_size =
> +				priv->options_dqo_rda.tx_comp_ring_entries;
> +		} else {
> +			qpl_id = tx->dqo.qpl->id;

The qpl field does not appear to be added to struct gve_tx_ring
until a following patch.

> +			comp_ring_size = priv->tx_desc_cnt;
> +		}
> +		cmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
>  		cmd.create_tx_queue.tx_ring_size =
>  			cpu_to_be16(priv->tx_desc_cnt);
>  		cmd.create_tx_queue.tx_comp_ring_addr =
>  			cpu_to_be64(tx->complq_bus_dqo);
>  		cmd.create_tx_queue.tx_comp_ring_size =
> -			cpu_to_be16(priv->options_dqo_rda.tx_comp_ring_entries);
> +			cpu_to_be16(comp_ring_size);
>  	}
>  
>  	return gve_adminq_issue_cmd(priv, &cmd);
> @@ -555,6 +586,18 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)
>  		cmd.create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
>  		cmd.create_rx_queue.packet_buffer_size = cpu_to_be16(rx->packet_buffer_size);
>  	} else {
> +		u16 rx_buff_ring_entries = 0;
> +		u32 qpl_id = 0;
> +
> +		if (priv->queue_format == GVE_DQO_RDA_FORMAT) {
> +			qpl_id = GVE_RAW_ADDRESSING_QPL_ID;
> +			rx_buff_ring_entries =
> +				priv->options_dqo_rda.rx_buff_ring_entries;
> +		} else {
> +			qpl_id = rx->dqo.qpl->id;

Likewise, the qpl field does not appear to be added to struct gve_rx_ring
until a following patch.

> +			rx_buff_ring_entries = priv->rx_desc_cnt;
> +		}
> +		cmd.create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
>  		cmd.create_rx_queue.rx_ring_size =
>  			cpu_to_be16(priv->rx_desc_cnt);
>  		cmd.create_rx_queue.rx_desc_ring_addr =

...

-- 
pw-bot: changes-requested