Subject: Re: [PATCH 2/4] net: ti: icss-iep: Add IEP driver

From: Simon Horman <[email-masked]>
Date: Thu, 3 Aug 2023 17:16:59 +0200

On Thu, Aug 03, 2023 at 04:31:51PM +0530, MD Danish Anwar wrote:
> From: Roger Quadros <[email-masked]>
> 
> Add a driver for Industrial Ethernet Peripheral (IEP) block of PRUSS to
> support timestamping of ethernet packets and thus support PTP and PPS
> for PRU ethernet ports.
> 
> Signed-off-by: Roger Quadros <[email-masked]>
> Signed-off-by: Lokesh Vutla <[email-masked]>
> Signed-off-by: Murali Karicheri <[email-masked]>
> Signed-off-by: Vignesh Raghavendra <[email-masked]>
> Signed-off-by: MD Danish Anwar <[email-masked]>

...

> +static int icss_iep_pps_enable(struct icss_iep *iep, int on)
> +{
> +	int ret = 0;
> +	struct timespec64 ts;
> +	struct ptp_clock_request rq;
> +	unsigned long flags;
> +	u64 ns;

For networking code, please arrange local variables in reverse xmas tree
order - longest line to shortest.

https://github.com/ecree-solarflare/xmastree is your friend here.

...