From: Simon Horman <horms@kernel•org>
To: Michal Schmidt <mschmidt@redhat•com>
Cc: netdev@vger•kernel.org, Veerasenareddy Burru <vburru@marvell•com>,
Sathesh Edara <sedara@marvell•com>,
"David S. Miller" <davem@davemloft•net>,
Abhijit Ayarekar <aayarekar@marvell•com>,
Satananda Burla <sburla@marvell•com>,
Vimlesh Kumar <vimleshk@marvell•com>
Subject: Re: [PATCH net 2/4] octeon_ep: cancel tx_timeout_task later in remove sequence
Date: Sat, 12 Aug 2023 19:43:00 +0200 [thread overview]
Message-ID: <ZNfEpKt9SlLWAaH3@vergenet.net> (raw)
In-Reply-To: <CADEbmW2tmCd5K852-z7VQfMmp=ae06_gOE66uduhnV3zbA4RcA@mail.gmail.com>
On Fri, Aug 11, 2023 at 05:58:44PM +0200, Michal Schmidt wrote:
> On Thu, Aug 10, 2023 at 5:48 PM Simon Horman <horms@kernel•org> wrote:
> >
> > On Thu, Aug 10, 2023 at 05:01:12PM +0200, Michal Schmidt wrote:
> > > tx_timeout_task is canceled too early when removing the driver. Nothing
> >
> > nit: canceled -> cancelled
> >
> > also elsewhere in this patchset
> >
> > ./checkpatch.pl --codespell is your friend here
> >
> > ...
>
> Hi Simon,
> thank you for the review.
>
> I think both spellings are valid.
> https://www.grammarly.com/blog/canceled-vs-cancelled/
Thanks, I did not know that.
> Do you want me to resend the patchset for this?
No, not in light of your previous point.
--
pw-bot: under-review
next prev parent reply other threads:[~2023-08-12 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 15:01 [PATCH net 0/4] octeon_ep: fixes for error and remove paths Michal Schmidt
2023-08-10 15:01 ` [PATCH net 1/4] octeon_ep: fix timeout value for waiting on mbox response Michal Schmidt
2023-08-10 15:50 ` Simon Horman
2023-08-10 15:01 ` [PATCH net 2/4] octeon_ep: cancel tx_timeout_task later in remove sequence Michal Schmidt
2023-08-10 15:48 ` Simon Horman
2023-08-11 15:58 ` Michal Schmidt
2023-08-12 17:43 ` Simon Horman [this message]
2023-08-10 15:01 ` [PATCH net 3/4] octeon_ep: cancel ctrl_mbox_task after intr_poll_task Michal Schmidt
2023-08-10 15:01 ` [PATCH net 4/4] octeon_ep: cancel queued works in probe error path Michal Schmidt
2023-08-15 2:10 ` [PATCH net 0/4] octeon_ep: fixes for error and remove paths patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNfEpKt9SlLWAaH3@vergenet.net \
--to=horms@kernel$(echo .)org \
--cc=aayarekar@marvell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mschmidt@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sburla@marvell$(echo .)com \
--cc=sedara@marvell$(echo .)com \
--cc=vburru@marvell$(echo .)com \
--cc=vimleshk@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox