From: Simon Horman <horms@kernel•org>
To: Alfred Lee <l00g33k@gmail•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
andrew@lunn•ch, olteanv@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
sgarzare@redhat•com, AVKrasnov@sberdevices•ru
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset
Date: Sun, 13 Aug 2023 17:32:03 +0200 [thread overview]
Message-ID: <ZNj3c2TO6bqfe0IM@vergenet.net> (raw)
In-Reply-To: <20230811232832.24321-1-l00g33k@gmail.com>
On Fri, Aug 11, 2023 at 04:28:32PM -0700, Alfred Lee wrote:
> If the switch is reset during active EEPROM transactions, as in
> just after an SoC reset after power up, the I2C bus transaction
> may be cut short leaving the EEPROM internal I2C state machine
> in the wrong state. When the switch is reset again, the bad
> state machine state may result in data being read from the wrong
> memory location causing the switch to enter unexpect mode
nit: unexpect -> unexpected
> rendering it inoperational.
>
> Fixes: 8abbffd27ced ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
> Signed-off-by: Alfred Lee <l00g33k@gmail•com>
prev parent reply other threads:[~2023-08-13 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 23:28 [PATCH v2 net] net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset Alfred Lee
2023-08-13 10:58 ` Vladimir Oltean
2023-08-13 15:09 ` Andrew Lunn
2023-08-13 18:53 ` Vladimir Oltean
2023-08-13 15:32 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNj3c2TO6bqfe0IM@vergenet.net \
--to=horms@kernel$(echo .)org \
--cc=AVKrasnov@sberdevices$(echo .)ru \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=l00g33k@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=sgarzare@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox