public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Simon Horman <horms@kernel•org>
To: Breno Leitao <leitao@debian•org>
Cc: rdunlap@infradead•org, benjamin.poirier@gmail•com,
	davem@davemloft•net, kuba@kernel•org, edumazet@google•com,
	netdev@vger•kernel.org, pabeni@redhat•com, horms@kernel•org
Subject: Re: [PATCH net-next v6 0/2] netconsole: Enable compile time configuration
Date: Tue, 15 Aug 2023 09:30:55 +0200	[thread overview]
Message-ID: <ZNspr0OlEKGD3K9c@vergenet.net> (raw)
In-Reply-To: <20230811093158.1678322-1-leitao@debian.org>

On Fri, Aug 11, 2023 at 02:31:56AM -0700, Breno Leitao wrote:
> Enable netconsole features to be set at compilation time. Create two
> Kconfig options that allow users to set extended logs and release
> prepending features at compilation time.
> 
> The first patch de-duplicates the initialization code, and the second
> patch adds the support in the de-duplicated code, avoiding touching two
> different functions with the same change.
> 
>   v1 -> v2:
> 	* Improvements in the Kconfig help section.
> 
>   v2 -> v3:
> 	* Honour the Kconfig settings when creating sysfs targets
> 	* Add "by default" in a Kconfig help.
> 
>   v3 -> v4:
> 	* Create an additional patch, de-duplicating the initialization
> 	  code for netconsole_target, and just patching it.
> 
>   v4 -> v5:
> 	* Remove complex code in the variable initialization.
> 
>   v5 -> v6:
> 	* Return -EINVAL for invalid configuration during
> 	  initialization.
> 
> Breno Leitao (2):
>   netconsole: Create a allocation helper
>   netconsole: Enable compile time configuration
> 
>  drivers/net/Kconfig      | 22 ++++++++++++++++++
>  drivers/net/netconsole.c | 48 +++++++++++++++++++++++-----------------
>  2 files changed, 50 insertions(+), 20 deletions(-)

Thanks Breno,

thanks for addressing the feedback given for previous revisions.

Reviewed-by: Simon Horman <horms@kernel•org>

next prev parent reply	other threads:[~2023-08-15  7:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  9:31 [PATCH net-next v6 0/2] netconsole: Enable compile time configuration Breno Leitao
2023-08-11  9:31 ` [PATCH net-next v6 1/2] netconsole: Create a allocation helper Breno Leitao
2023-08-11  9:31 ` [PATCH net-next v6 2/2] netconsole: Enable compile time configuration Breno Leitao
2023-08-15  7:30 ` Simon Horman [this message]
2023-08-18  3:10 ` [PATCH net-next v6 0/2] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNspr0OlEKGD3K9c@vergenet.net \
    --to=horms@kernel$(echo .)org \
    --cc=benjamin.poirier@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=leitao@debian$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=rdunlap@infradead$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox