Subject: Re: [PATCH 1/3] netconsole: Initialize configfs_item for default targets

From: Joel Becker <[email-masked]>
Date: Wed, 4 Oct 2023 12:59:38 -0700

On Mon, Oct 02, 2023 at 08:53:47AM -0700, Breno Leitao wrote:
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index 3111e1648592..b68456054a0c 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -53,6 +53,8 @@ static bool oops_only = false;
>  module_param(oops_only, bool, 0600);
>  MODULE_PARM_DESC(oops_only, "Only log oops messages");
>  
> +#define DEFAULT_TARGET_NAME "cmdline"
> +

I'm not sure `DEFAULT` is the right terminology here.  e.g. it's not a
default for dynamic targets, etc.  Perhaps `BOOT_TARGET_NAME` or
`NETCONSOLE_PARAM_TARGET_NAME`?

Joel

-- 

"Friends may come and go, but enemies accumulate." 
        - Thomas Jones

			http://www.jlbec.org/
			[email-masked]