Subject: Re: [PATCH 3/3] Documentation: netconsole: add support for cmdline targets

From: Joel Becker <[email-masked]>
Date: Wed, 4 Oct 2023 13:09:16 -0700

On Mon, Oct 02, 2023 at 08:53:49AM -0700, Breno Leitao wrote:
> @@ -155,6 +152,24 @@ You can also update the local interface dynamically. This is especially
>  useful if you want to use interfaces that have newly come up (and may not
>  have existed when netconsole was loaded / initialized).
>  
> +You can control and modify the targets defined at boot time (or module load
> +time) by creating special targets names. These special targets are named
> +`cmdline` concatenated to an integer, example: `cmdline0`.

The special names are already "created", so perhaps it's a little
clearer to say something like:

```
+Netconsole targets defined at boot time (or module load time) with the
+`netconsole=` param are assigned the name `cmdline<index>`.  For
+example, the first target in the parameter is named `cmdline0`.  You
+can control and modify these targets by creating configfs directories
+with the matching name.
```

> +
> +Let's suppose you have two netconsole targets defined at boot time::
> +
> + netconsole=[email-masked]/eth1,[email-masked]/12:34:56:78:9a:bc;[email-masked]/eth1,[email-masked]/12:34:56:78:9a:bc
> +
> +You can modify these targets in runtime by creating the following targets::
> +
> + mkdir cmdline0
> + cat cmdline0/remote_ip
> + 10.0.0.2
> +
> + mkdir cmdline1
> + cat cmdline1/remote_ip
> + 10.0.0.3
> +

And of course keep the examples as you've described them.

Thanks,
Joel

-- 

Life's Little Instruction Book #337

	"Reread your favorite book."

			http://www.jlbec.org/
			[email-masked]