From: Phillip Potter <phil@philpotter•co.uk>
To: Joel Granados <j.granados@samsung•com>
Cc: Luis Chamberlain <mcgrof@kernel•org>,
willy@infradead•org, josh@joshtriplett•org,
Kees Cook <keescook@chromium•org>,
Clemens Ladisch <clemens@ladisch•de>,
Arnd Bergmann <arnd@arndb•de>, Juergen Gross <jgross@suse•com>,
Stefano Stabellini <sstabellini@kernel•org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam•com>,
Jiri Slaby <jirislaby@kernel•org>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
Doug Gilbert <dgilbert@interlog•com>,
Sudip Mukherjee <sudipm.mukherjee@gmail•com>,
Jason Gunthorpe <jgg@ziepe•ca>, Leon Romanovsky <leon@kernel•org>,
Corey Minyard <minyard@acm•org>, Theodore Ts'o <tytso@mit•edu>,
"Jason A. Donenfeld" <Jason@zx2c4•com>,
David Ahern <dsahern@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Robin Holt <robinmholt@gmail•com>,
Steve Wahl <steve.wahl@hpe•com>,
Russ Weight <russell.h.weight@intel•com>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Song Liu <song@kernel•org>,
"K. Y. Srinivasan" <kys@microsoft•com>,
Haiyang Zhang <haiyangz@microsoft•com>,
Wei Liu <wei.liu@kernel•org>, Dexuan Cui <decui@microsoft•com>,
Jani Nikula <jani.nikula@linux•intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux•intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel•com>,
Tvrtko Ursulin <tvrtko.ursulin@linux•intel.com>,
David Airlie <airlied@gmail•com>, Daniel Vetter <daniel@ffwll•ch>,
linux-kernel@vger•kernel.org, xen-devel@lists•xenproject.org,
linux-serial@vger•kernel.org, linux-scsi@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-rdma@vger•kernel.org,
openipmi-developer@lists•sourceforge.net, netdev@vger•kernel.org,
linux-raid@vger•kernel.org, linux-hyperv@vger•kernel.org,
intel-gfx@lists•freedesktop.org, dri-devel@lists•freedesktop.org,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array
Date: Sat, 30 Sep 2023 17:52:17 +0100 [thread overview]
Message-ID: <ZRhSQaNDJih5xABq@equinox> (raw)
In-Reply-To: <20230929121730.bwzhrpaptf45smfy@localhost>
On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote:
> On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote:
> > > From: Joel Granados <j.granados@samsung•com>
> > >
> > > This commit comes at the tail end of a greater effort to remove the
> > > empty elements at the end of the ctl_table arrays (sentinels) which
> > > will reduce the overall build time size of the kernel and run time
> > > memory bloat by ~64 bytes per sentinel (further information Link :
> > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> > >
> > > Remove sentinel element from cdrom_table
> > >
> > > Signed-off-by: Joel Granados <j.granados@samsung•com>
> > > ---
> > > drivers/cdrom/cdrom.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> > > index cc2839805983..451907ade389 100644
> > > --- a/drivers/cdrom/cdrom.c
> > > +++ b/drivers/cdrom/cdrom.c
> > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = {
> > > .maxlen = sizeof(int),
> > > .mode = 0644,
> > > .proc_handler = cdrom_sysctl_handler
> > > - },
> > > - { }
> > > + }
> >
> > You should have the final entry as "}," so as to make any future
> > additions to the list to only contain that entry, that's long been the
> > kernel style for lists like this.
> Will send a V2 with this included. Thx.
>
> >
> > So your patches will just remove one line, not 2 and add 1, making it a
> > smaller diff.
> indeed.
>
> >
> > thanks,
> >
> > greg k-h
>
> --
>
> Joel Granados
Hi Joel,
Thank you for your patch. I look forward to seeing V2, and will be happy
to review it.
Regards,
Phil
next prev parent reply other threads:[~2023-09-30 16:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 13:21 [PATCH 00/15] sysctl: Remove sentinel elements from drivers Joel Granados via B4 Relay
[not found] ` <20230928-jag-sysctl_remove_empty_elem_drive>
2023-09-28 13:21 ` [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Joel Granados via B4 Relay
2023-09-28 13:36 ` Greg Kroah-Hartman
2023-09-29 12:17 ` Joel Granados
2023-09-30 16:52 ` Phillip Potter [this message]
2023-10-02 7:39 ` Joel Granados
2023-09-28 13:21 ` [PATCH 02/15] hpet: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 03/15] xen: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 04/15] tty: " Joel Granados via B4 Relay
2023-10-02 8:17 ` Jiri Slaby
2023-10-02 8:47 ` Christophe Leroy
2023-10-02 9:02 ` Greg Kroah-Hartman
2023-09-28 13:21 ` [PATCH 05/15] scsi: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 06/15] parport: Remove the " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 07/15] macintosh: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 08/15] infiniband: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 09/15] char-misc: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 10/15] vrf: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 11/15] sgi-xp: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 12/15] fw loader: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 13/15] raid: Remove " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 14/15] hyper-v/azure: " Joel Granados via B4 Relay
2023-09-28 13:21 ` [PATCH 15/15] intel drm: " Joel Granados via B4 Relay
[not found] ` <65157da7.5d0a0220.13b5e.9e95SMTPIN_ADDED_BROKEN@mx.google.com>
2023-09-28 15:20 ` [PATCH 13/15] raid: " Song Liu
[not found] ` <65157da8.050a0220.fb263.fdb1SMTPIN_ADDED_BROKEN@mx.google.com>
2023-09-28 15:26 ` [PATCH 14/15] hyper-v/azure: " Wei Liu
2023-09-29 12:15 ` Joel Granados
2023-09-29 14:03 ` Joel Granados
2023-09-28 16:31 ` [PATCH 00/15] sysctl: Remove sentinel elements from drivers Christophe Leroy
2023-10-02 8:47 ` Joel Granados
2023-10-02 9:02 ` Christophe Leroy
[not found] ` <=?utf-8?q?=3C20230928-jag-sysctl=5Fremove=5Fempty=5Felem=5Fdrive?=>
2023-09-28 17:51 ` [PATCH 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array Steve Wahl
2023-09-29 12:14 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRhSQaNDJih5xABq@equinox \
--to=phil@philpotter$(echo .)co.uk \
--cc=Jason@zx2c4$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=clemens@ladisch$(echo .)de \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=dgilbert@interlog$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=j.granados@samsung$(echo .)com \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jgross@suse$(echo .)com \
--cc=jirislaby@kernel$(echo .)org \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=josh@joshtriplett$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-raid@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=minyard@acm$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=pabeni@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=robinmholt@gmail$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=russell.h.weight@intel$(echo .)com \
--cc=song@kernel$(echo .)org \
--cc=sstabellini@kernel$(echo .)org \
--cc=steve.wahl@hpe$(echo .)com \
--cc=sudipm.mukherjee@gmail$(echo .)com \
--cc=tvrtko.ursulin@linux$(echo .)intel.com \
--cc=tytso@mit$(echo .)edu \
--cc=wei.liu@kernel$(echo .)org \
--cc=willy@infradead$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox