From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Eric Dumazet <edumazet@google•com>
Cc: Miquel Raynal <miquel.raynal@bootlin•com>,
Wei Fang <wei.fang@nxp•com>, Shenwei Wang <shenwei.wang@nxp•com>,
Clark Wang <xiaoning.wang@nxp•com>,
davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
linux-imx@nxp•com, netdev@vger•kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Andrew Lunn <andrew@lunn•ch>,
Stephen Hemminger <stephen@networkplumber•org>
Subject: Re: Ethernet issue on imx6
Date: Mon, 16 Oct 2023 22:47:11 +0100 [thread overview]
Message-ID: <ZS2vX9cUAbpx9X3t@shell.armlinux.org.uk> (raw)
In-Reply-To: <CANn89iLxKQOY5ZA5o3d1y=v4MEAsAQnzmVDjmLY0_bJPG93tKQ@mail.gmail.com>
On Mon, Oct 16, 2023 at 09:37:58PM +0200, Eric Dumazet wrote:
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 77c8e9cfb44562e73bfa89d06c5d4b179d755502..520436d579d66cc3263527373d754a206cb5bcd6
> 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -753,7 +753,6 @@ fec_enet_txq_put_hdr_tso(struct fec_enet_priv_tx_q *txq,
> struct fec_enet_private *fep = netdev_priv(ndev);
> int hdr_len = skb_tcp_all_headers(skb);
> struct bufdesc_ex *ebdp = container_of(bdp, struct bufdesc_ex, desc);
> - void *bufaddr;
> unsigned long dmabuf;
> unsigned short status;
> unsigned int estatus = 0;
> @@ -762,11 +761,11 @@ fec_enet_txq_put_hdr_tso(struct fec_enet_priv_tx_q *txq,
> status &= ~BD_ENET_TX_STATS;
> status |= (BD_ENET_TX_TC | BD_ENET_TX_READY);
>
> - bufaddr = txq->tso_hdrs + index * TSO_HEADER_SIZE;
> dmabuf = txq->tso_hdrs_dma + index * TSO_HEADER_SIZE;
> - if (((unsigned long)bufaddr) & fep->tx_align ||
> - fep->quirks & FEC_QUIRK_SWAP_FRAME) {
> - memcpy(txq->tx_bounce[index], skb->data, hdr_len);
> + if (fep->quirks & FEC_QUIRK_SWAP_FRAME) {
> + void *bufaddr = txq->tso_hdrs + index * TSO_HEADER_SIZE;
> +
> + memcpy(txq->tx_bounce[index], bufaddr, hdr_len);
> bufaddr = txq->tx_bounce[index];
>
> if (fep->quirks & FEC_QUIRK_SWAP_FRAME)
I'm not sure this has any effect on the reported issue.
1. For imx6 based devices, FEC_QUIRK_SWAP_FRAME is not set.
2. fep->tx_align is 15, TSO_HEADER_SIZE is 256, and ->tso_hdrs is
derived from dma_alloc_coherent() which will be page aligned.
So this condition will also always be false.
So, while the patch looks correct to me, I think it will only have an
effect on imx28 based systems that set FEC_QUIRK_SWAP_FRAME, and for
that it looks correct to me, since the header is always located in
txq->tso_hdrs and we need to copy it from there into the "bounce"
buffer.
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-10-16 21:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 17:34 Ethernet issue on imx6 Miquel Raynal
2023-10-12 19:39 ` Russell King (Oracle)
2023-10-13 8:40 ` Miquel Raynal
2023-10-13 10:16 ` Wei Fang
2023-10-16 11:49 ` Eric Dumazet
2023-10-16 13:58 ` Miquel Raynal
2023-10-16 15:06 ` Eric Dumazet
2023-10-16 15:36 ` Miquel Raynal
2023-10-16 19:37 ` Eric Dumazet
2023-10-16 21:47 ` Russell King (Oracle) [this message]
2023-10-17 11:19 ` Miquel Raynal
2023-10-12 20:46 ` Andrew Lunn
2023-10-12 22:58 ` Stephen Hemminger
2023-10-13 8:27 ` Miquel Raynal
2023-10-13 15:51 ` Andrew Lunn
2023-10-27 20:58 ` Miquel Raynal
2023-11-17 15:09 ` Miquel Raynal
2023-10-16 8:48 ` Alexander Stein
2023-10-16 13:31 ` Miquel Raynal
2023-10-16 14:41 ` Alexander Stein
2023-10-17 10:49 ` Miquel Raynal
2023-10-18 9:08 ` Alexander Stein
2023-10-27 20:58 ` Miquel Raynal
2023-10-13 8:50 ` James Chapman
2023-10-13 10:37 ` Miquel Raynal
2023-10-13 11:54 ` James Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS2vX9cUAbpx9X3t@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-imx@nxp$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shenwei.wang@nxp$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
--cc=xiaoning.wang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox