Subject: Re: [PATCH net-next v2 1/3] netconsole: Initialize configfs_item for default targets

From: Breno Leitao <[email-masked]>
Date: Tue, 10 Oct 2023 02:36:14 -0700

On Mon, Oct 09, 2023 at 07:31:58PM -0700, Jakub Kicinski wrote:
> On Thu,  5 Oct 2023 05:36:34 -0700 Breno Leitao wrote:
> > +static void populate_configfs_item(struct netconsole_target *nt,
> > +				   int cmdline_count);
> 
> Could you move alloc / free_param_target() to avoid the forward
> declaration? (separate patch)

Yes, this is a good idea. I tried to avoid the forward declaration, but
I didn't find this solution. Sending a v3 with this change.

Thanks for the review!