From: Benjamin Poirier <benjamin.poirier@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Coiby Xu <coiby.xu@gmail•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Shannon Nelson <shannon.nelson@amd•com>,
Michael Chan <michael.chan@broadcom•com>,
Cai Huoqing <cai.huoqing@linux•dev>,
George Cherian <george.cherian@marvell•com>,
Danielle Ratson <danieller@nvidia•com>,
Moshe Shemesh <moshe@nvidia•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Ariel Elior <aelior@marvell•com>,
Manish Chopra <manishc@marvell•com>,
Igor Russkikh <irusskikh@marvell•com>,
Brett Creeley <brett.creeley@amd•com>,
Sunil Goutham <sgoutham@marvell•com>,
Linu Cherian <lcherian@marvell•com>,
Geetha sowjanya <gakula@marvell•com>,
Jerin Jacob <jerinj@marvell•com>, hariprasad <hkelam@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Ido Schimmel <idosch@nvidia•com>, Petr Machata <petrm@nvidia•com>,
Eran Ben Elisha <eranbe@nvidia•com>,
Aya Levin <ayal@mellanox•com>, Leon Romanovsky <leon@kernel•org>,
linux-kernel@vger•kernel.org,
Shung-Hsi Yu <shung-hsi.yu@suse•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Subject: Re: [PATCH net-next v2 10/11] staging: qlge: devlink health: use retained error fmsg API
Date: Thu, 19 Oct 2023 14:32:19 -0400 [thread overview]
Message-ID: <ZTF2M7VeNtisGBm7@d3> (raw)
In-Reply-To: <20231019074237.7ef255d7@kernel.org>
On 2023-10-19 07:42 -0700, Jakub Kicinski wrote:
> On Thu, 19 Oct 2023 10:28:03 -0400 Benjamin Poirier wrote:
> > > Humpf. Unrelated to the set, when did qlge grow devlink support?!
> > >
> > > Coiby, do you still use this HW?
> > >
> > > It looks like the driver was moved to staging on account of being
> > > old and unused, and expecting that we'll delete it. Clearly that's
> > > not the case if people are adding devlink support, so should we
> > > move it back?
> >
> > AFAIK this was done by Coiby as an exercise in kernel programming.
> > Improving the debugging dump facilities was one of the tasks in the TODO
> > file.
> >
> > I moved the driver to staging because it had many problems and it had
> > been abandoned by the vendor. There might be some qlge users left but is
> > that reason enough to move the driver back to drivers/net/
> > if there is no one who is interested in doing more than checkpatch
> > fixes on the driver?
>
> Staging is usually an area for code entering the kernel, not leaving.
> We should either suffer with it under drivers/net/ or delete it,
> as you say, nobody is working on significant improvements so having
> the driver in staging is serving no purpose.
>
> How about we delete it completely, and if someone complains bring
> it back under drivers/net ?
That sounds like a reasonable way forward, thank you. I'll send a patch
to do the removal.
next prev parent reply other threads:[~2023-10-19 18:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 10:53 [PATCH net-next v2 00/11] devlink: retain error in struct devlink_fmsg Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 01/11] " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 02/11] netdevsim: devlink health: use retained error fmsg API Przemek Kitszel
2023-10-18 1:20 ` Jakub Kicinski
2023-10-17 10:53 ` [PATCH net-next v2 03/11] pds_core: " Przemek Kitszel
2023-10-17 11:06 ` Jiri Pirko
2023-10-17 11:15 ` Jiri Pirko
2023-10-17 11:35 ` Przemek Kitszel
2023-10-17 16:52 ` Nelson, Shannon
2023-10-17 10:53 ` [PATCH net-next v2 04/11] bnxt_en: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 05/11] hinic: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 06/11] octeontx2-af: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 07/11] mlxsw: core: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 08/11] net/mlx5: " Przemek Kitszel
2023-10-18 16:08 ` Simon Horman
2023-10-17 10:53 ` [PATCH net-next v2 09/11] qed: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 10/11] staging: qlge: " Przemek Kitszel
2023-10-18 1:15 ` Jakub Kicinski
2023-10-19 14:28 ` Benjamin Poirier
2023-10-19 14:42 ` Jakub Kicinski
2023-10-19 18:32 ` Benjamin Poirier [this message]
2023-10-17 10:53 ` [PATCH net-next v2 11/11] devlink: convert most of devlink_fmsg_*() to return void Przemek Kitszel
2023-10-18 16:10 ` Simon Horman
2023-10-17 11:17 ` [PATCH net-next v2 00/11] devlink: retain error in struct devlink_fmsg Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTF2M7VeNtisGBm7@d3 \
--to=benjamin.poirier@gmail$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=ayal@mellanox$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=cai.huoqing@linux$(echo .)dev \
--cc=coiby.xu@gmail$(echo .)com \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eranbe@nvidia$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=george.cherian@marvell$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hkelam@marvell$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=irusskikh@marvell$(echo .)com \
--cc=jerinj@marvell$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=lcherian@marvell$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manishc@marvell$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=shung-hsi.yu@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox