From: Stanislav Fomichev <sdf@google•com>
To: Magnus Karlsson <magnus.karlsson@gmail•com>
Cc: bpf@vger•kernel.org, ast@kernel•org, daniel@iogearbox•net,
andrii@kernel•org, martin.lau@linux•dev, song@kernel•org,
yhs@fb•com, john.fastabend@gmail•com, kpsingh@kernel•org,
haoluo@google•com, jolsa@kernel•org, kuba@kernel•org,
toke@kernel•org, willemb@google•com, dsahern@kernel•org,
magnus.karlsson@intel•com, bjorn@kernel•org,
maciej.fijalkowski@intel•com, hawk@kernel•org,
yoong.siang.song@intel•com, netdev@vger•kernel.org,
xdp-hints@xdp-project•net
Subject: Re: [PATCH bpf-next v4 00/11] xsk: TX metadata
Date: Mon, 23 Oct 2023 11:38:16 -0700 [thread overview]
Message-ID: <ZTa9mO5esjWnW8Oo@google.com> (raw)
In-Reply-To: <CAJ8uoz26Q-8etBpgc25xFY8ZRcoJeAM5RFOWO-Q2_T1=xBfL9g@mail.gmail.com>
On 10/23, Magnus Karlsson wrote:
> On Thu, 19 Oct 2023 at 19:49, Stanislav Fomichev <sdf@google•com> wrote:
> >
> > This series implements initial TX metadata (offloads) for AF_XDP.
> > See patch #2 for the main implementation and mlx5/stmmac ones for the
> > example on how to consume the metadata on the device side.
> >
> > Starting with two types of offloads:
> > - request TX timestamp (and write it back into the metadata area)
> > - request TX checksum offload
> >
> > Changes since v3:
> > - fix xsk_tx_metadata_ops kdoc (Song Yoong Siang)
> > - add missing xsk_tx_metadata_to_compl for XDP_SOCKETS=n (Vinicius Costa Gomes and Intel bots)
> > - add reference timestamps to the selftests + refactor existing ones (Jesper)
> >
> > v3: https://lore.kernel.org/bpf/20231003200522.1914523-1-sdf@google.com/
>
> Thanks for working on this Stanislav. I went through the patch set and
> it looks good to me. You have addressed all the feedback that Maciej
> and I had on a previous version. Just had some small things in two of
> the patches. Apart from that, you are good to go and you can add my
> ack to the next version.
>
> Acked-by: Magnus Karlsson <magnus.karlsson@intel•com>
>
> Again, really appreciate all your work with this!
Thank you! Appreciate the review and comments as well!
prev parent reply other threads:[~2023-10-23 18:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 17:49 [PATCH bpf-next v4 00/11] xsk: TX metadata Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 01/11] xsk: Support tx_metadata_len Stanislav Fomichev
2023-10-20 14:29 ` Song, Yoong Siang
2023-10-21 1:12 ` Jakub Kicinski
2023-10-23 17:33 ` Stanislav Fomichev
2023-10-23 8:28 ` Magnus Karlsson
2023-10-23 18:37 ` Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 02/11] xsk: Add TX timestamp and TX checksum offload support Stanislav Fomichev
2023-10-20 14:31 ` Song, Yoong Siang
2023-10-20 17:49 ` Alexei Starovoitov
2023-10-20 18:06 ` Stanislav Fomichev
2023-10-21 1:04 ` Jakub Kicinski
2023-10-23 17:21 ` Stanislav Fomichev
2023-10-23 18:12 ` Jakub Kicinski
2023-10-23 18:46 ` Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 03/11] tools: ynl: Print xsk-features from the sample Stanislav Fomichev
2023-10-21 1:06 ` Jakub Kicinski
2023-10-23 17:27 ` Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 04/11] net/mlx5e: Implement AF_XDP TX timestamp and checksum offload Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 05/11] net: stmmac: Add Tx HWTS support to XDP ZC Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 06/11] selftests/xsk: Support tx_metadata_len Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 07/11] selftests/bpf: Add csum helpers Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 08/11] selftests/bpf: Add TX side to xdp_metadata Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 09/11] selftests/bpf: Convert xdp_hw_metadata to XDP_USE_NEED_WAKEUP Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 10/11] selftests/bpf: Add TX side to xdp_hw_metadata Stanislav Fomichev
2023-10-24 2:19 ` Song, Yoong Siang
2023-10-24 16:41 ` Stanislav Fomichev
2023-10-19 17:49 ` [PATCH bpf-next v4 11/11] xsk: Document tx_metadata_len layout Stanislav Fomichev
2023-10-23 9:19 ` Magnus Karlsson
2023-10-23 18:31 ` Stanislav Fomichev
2023-10-23 9:52 ` [PATCH bpf-next v4 00/11] xsk: TX metadata Magnus Karlsson
2023-10-23 18:38 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTa9mO5esjWnW8Oo@google.com \
--to=sdf@google$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=haoluo@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@gmail$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=song@kernel$(echo .)org \
--cc=toke@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
--cc=xdp-hints@xdp-project$(echo .)net \
--cc=yhs@fb$(echo .)com \
--cc=yoong.siang.song@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox