From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Heiner Kallweit <hkallweit1@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: phylink: use for_each_set_bit()
Date: Fri, 17 Nov 2023 16:17:22 +0000 [thread overview]
Message-ID: <ZVeSEv2nN1xioYz5@shell.armlinux.org.uk> (raw)
In-Reply-To: <84b4b1b4-83e7-477b-9316-21c7a76689aa@lunn.ch>
On Fri, Nov 17, 2023 at 05:15:17PM +0100, Andrew Lunn wrote:
> > + t = *state;
> > + t.interface = interface;
> > + if (!phylink_validate_mac_and_pcs(pl, s, &t)) {
> > + linkmode_or(all_s, all_s, s);
> > + linkmode_or(all_adv, all_adv, t.advertising);
> > }
> > }
> >
> > +
> > linkmode_copy(supported, all_s);
>
> Adding another blank line here was probably unintentional?
Hmm, indeed, thanks for spotting. I always forget whether I'll need to
send a v2 for something this trivial or whether netdev folk will fix
it up when committing it. I'm happy to resend.
> Otherwise:
>
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-11-17 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:57 [PATCH net-next] net: phylink: use for_each_set_bit() Russell King (Oracle)
2023-11-17 16:15 ` Andrew Lunn
2023-11-17 16:17 ` Russell King (Oracle) [this message]
2023-11-17 16:30 ` Andrew Lunn
2023-11-17 16:32 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVeSEv2nN1xioYz5@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox