Subject: Re: [PATCH net-next] net: phylink: use for_each_set_bit()

From: "Russell King (Oracle)" <[email-masked]>
Date: Fri, 17 Nov 2023 16:17:22 +0000

On Fri, Nov 17, 2023 at 05:15:17PM +0100, Andrew Lunn wrote:
> > +		t = *state;
> > +		t.interface = interface;
> > +		if (!phylink_validate_mac_and_pcs(pl, s, &t)) {
> > +			linkmode_or(all_s, all_s, s);
> > +			linkmode_or(all_adv, all_adv, t.advertising);
> >  		}
> >  	}
> >  
> > +
> >  	linkmode_copy(supported, all_s);
> 
> Adding another blank line here was probably unintentional?

Hmm, indeed, thanks for spotting. I always forget whether I'll need to
send a v2 for something this trivial or whether netdev folk will fix
it up when committing it. I'm happy to resend.

> Otherwise:
> 
> Reviewed-by: Andrew Lunn <[email-masked]>

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!