From: Pablo Neira Ayuso <pablo@netfilter•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: jhs@mojatatu•com, Vlad Buslov <vladbu@nvidia•com>,
davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
netdev@vger•kernel.org, louis.peens@corigine•com,
yinjun.zhang@corigine•com, simon.horman@corigine•com,
jiri@resnulli•us, xiyou.wangcong@gmail•com,
Paul Blakey <paulb@nvidia•com>
Subject: Re: [PATCH net] net/sched: act_ct: Take per-cb reference to tcf_ct_flow_table
Date: Mon, 11 Dec 2023 10:30:16 +0100 [thread overview]
Message-ID: <ZXbWqP3oO7gtliMK@calendula> (raw)
In-Reply-To: <20231208154035.7cbec2f7@kernel.org>
On Fri, Dec 08, 2023 at 03:40:35PM -0800, Jakub Kicinski wrote:
> On Tue, 5 Dec 2023 18:25:54 +0100 Vlad Buslov wrote:
> > The referenced change added custom cleanup code to act_ct to delete any
> > callbacks registered on the parent block when deleting the
> > tcf_ct_flow_table instance. However, the underlying issue is that the
> > drivers don't obtain the reference to the tcf_ct_flow_table instance when
> > registering callbacks which means that not only driver callbacks may still
> > be on the table when deleting it but also that the driver can still have
> > pointers to its internal nf_flowtable and can use it concurrently which
> > results either warning in netfilter[0] or use-after-free.
> >
> > Fix the issue by taking a reference to the underlying struct
> > tcf_ct_flow_table instance when registering the callback and release the
> > reference when unregistering. Expose new API required for such reference
> > counting by adding two new callbacks to nf_flowtable_type and implementing
> > them for act_ct flowtable_ct type. This fixes the issue by extending the
> > lifetime of nf_flowtable until all users have unregistered.
>
> Some acks would be good here - Pablo, Jamal?
Acked-by: Pablo Neira Ayuso <pablo@netfilter•org>
I'd prefer driver does not access nf_flowtable directly, I already
mentioned this in the past.
next prev parent reply other threads:[~2023-12-11 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 17:25 [PATCH net] net/sched: act_ct: Take per-cb reference to tcf_ct_flow_table Vlad Buslov
2023-12-06 9:31 ` Louis Peens
2023-12-08 23:40 ` Jakub Kicinski
2023-12-11 9:30 ` Pablo Neira Ayuso [this message]
2023-12-11 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXbWqP3oO7gtliMK@calendula \
--to=pablo@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=louis.peens@corigine$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paulb@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=vladbu@nvidia$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=yinjun.zhang@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox