From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Peter Hilber <peter.hilber@opensynergy•com>
Cc: linux-kernel@vger•kernel.org, "D,
Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel•com>,
Thomas Gleixner <tglx@linutronix•de>,
jstultz@google•com, giometti@enneenne•com, corbet@lwn•net, "Dong,
Eddie" <eddie.dong@intel•com>,
"Hall, Christopher S" <christopher.s.hall@intel•com>,
Marc Zyngier <maz@kernel•org>,
linux-arm-kernel@lists•infradead.org,
Sean Christopherson <seanjc@google•com>,
Paolo Bonzini <pbonzini@redhat•com>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
Wanpeng Li <wanpengli@tencent•com>,
Vitaly Kuznetsov <vkuznets@redhat•com>,
Mark Rutland <mark.rutland@arm•com>,
Daniel Lezcano <daniel.lezcano@linaro•org>,
Richard Cochran <richardcochran@gmail•com>,
kvm@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [RFC PATCH v2 3/7] x86/kvm, ptp/kvm: Add clocksource ID, set system_counterval_t.cs_id
Date: Mon, 18 Dec 2023 12:23:32 +0200 [thread overview]
Message-ID: <ZYAdpPfFa2jlmZ44@smile.fi.intel.com> (raw)
In-Reply-To: <20231215220612.173603-4-peter.hilber@opensynergy.com>
On Fri, Dec 15, 2023 at 11:06:08PM +0100, Peter Hilber wrote:
> Add a clocksource ID for the x86 kvmclock.
>
> Also, for ptp_kvm, set the recently added struct system_counterval_t member
> cs_id to the clocksource ID (x86 kvmclock or Arm Generic Timer). In the
> future, this will keep get_device_system_crosststamp() working, when it
> will compare the clocksource id in struct system_counterval_t, rather than
> the clocksource.
>
> For now, to avoid touching too many subsystems at once, extract the
> clocksource ID from the clocksource. The clocksource dereference will be
> removed in the following.
...
> #include <linux/clocksource.h>
> +#include <linux/clocksource_ids.h>
It's the second file that includes both.
I'm just wondering if it makes sense to always (?) include the latter into
the former.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-18 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 22:06 [RFC PATCH v2 0/7] treewide: Use clocksource id for get_device_system_crosststamp() Peter Hilber
2023-12-15 22:06 ` [RFC PATCH v2 1/7] timekeeping: Add clocksource ID to struct system_counterval_t Peter Hilber
2023-12-15 22:06 ` [RFC PATCH v2 2/7] x86/tsc: Add clocksource ID, set system_counterval_t.cs_id Peter Hilber
2023-12-24 16:27 ` Simon Horman
2024-01-11 11:34 ` Peter Hilber
2024-01-25 20:13 ` Thomas Gleixner
2023-12-15 22:06 ` [RFC PATCH v2 3/7] x86/kvm, ptp/kvm: " Peter Hilber
2023-12-18 10:23 ` Andy Shevchenko [this message]
2024-01-11 11:32 ` Peter Hilber
2023-12-15 22:06 ` [RFC PATCH v2 4/7] ptp/kvm, arm_arch_timer: Set system_counterval_t.cs_id to constant Peter Hilber
2023-12-15 22:06 ` [RFC PATCH v2 5/7] timekeeping: Evaluate system_counterval_t.cs_id instead of .cs Peter Hilber
2023-12-15 22:06 ` [RFC PATCH v2 6/7] treewide: Remove system_counterval_t.cs, which is never read Peter Hilber
2023-12-15 22:06 ` [RFC PATCH v2 7/7] kvmclock: Unexport kvmclock clocksource Peter Hilber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYAdpPfFa2jlmZ44@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bp@alien8$(echo .)de \
--cc=christopher.s.hall@intel$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=eddie.dong@intel$(echo .)com \
--cc=giometti@enneenne$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jstultz@google$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=lakshmi.sowjanya.d@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pbonzini@redhat$(echo .)com \
--cc=peter.hilber@opensynergy$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=vkuznets@redhat$(echo .)com \
--cc=wanpengli@tencent$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox