Subject: Re: [PATCH net-next] genetlink: Use internal flags for multicast groups

From: Ido Schimmel <[email-masked]>
Date: Mon, 18 Dec 2023 18:31:10 +0200

On Mon, Dec 18, 2023 at 01:37:41PM +0200, Andy Shevchenko wrote:
> No functional, but documentation changes...
> 
> So, I suggest to have these flags being described
> 
> /* ... */
> #define FLAG1
> 
> /* ... */
> #define FLAG2

OK, thanks. I will squash the following diff into v2:

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 5a402fd24817..bd6a6ffdec76 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -8,7 +8,9 @@
 
 #define GENLMSG_DEFAULT_SIZE (NLMSG_DEFAULT_SIZE - GENL_HDRLEN)
 
+/* Binding to multicast group requires %CAP_NET_ADMIN */
 #define GENL_MCAST_CAP_NET_ADMIN       BIT(0)
+/* Binding to multicast group requires %CAP_SYS_ADMIN */
 #define GENL_MCAST_CAP_SYS_ADMIN       BIT(1)
 
 /**