From: fuyao <fuyao@sjterm•com>
To: "Jernej Škrabec" <jernej.skrabec@gmail•com>
Cc: "Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Jose Abreu" <joabreu@synopsys•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>, "Chen-Yu Tsai" <wens@csie•org>,
"Samuel Holland" <samuel@sholland•org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
netdev@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-sunxi@lists•linux.dev,
linux-stm32@st-md-mailman•stormreply.com,
linux-kernel@vger•kernel.org,
麦健建 <maijianzhang@allwinnertech•com>
Subject: Re: [PATCH] gmac: sun8i: r40: add gmac tx_delay support
Date: Thu, 21 Dec 2023 15:16:54 +0800 [thread overview]
Message-ID: <ZYPmZj8l01eQsDS5@debian.cyg> (raw)
In-Reply-To: <2370947.NG923GbCHz@jernej-laptop>
On Wed, Dec 20, 2023 at 06:04:28PM +0100, Jernej Škrabec wrote:
> Dne sreda, 20. december 2023 ob 10:08:25 CET je fuyao napisal(a):
> > r40 can support tx_delay, so we add it.
>
> I don't see how. User manual, 3.3.4.64. GMAC Clock Register talks only
> about RX delay.
>
I don't see it in the user manual also.
it works fine in 100M, but it doesn't work good in 1G without tx_delay
in my board.
Read the sdk from allwinner I found in:
https://sourcegraph.com/github.com/tinalinux/linux-3.10/-/blob/arch/arm/boot/dts/sun8iw11p1.dtsi?L1826
https://sourcegraph.com/github.com/tinalinux/linux-3.10@r40-v1.y/-/blob/drivers/net/ethernet/allwinner/sunxi-gmac.c?L877
And I add it to my board, it works fine.
So, I think it may be exist register but not documented.
Best regards,
fuyao
> Best regards,
> Jernej
>
> >
> > Signed-off-by: fuyao <fuyao1697@cyg•com>
> > ---
> > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> > index 137741b94122..fd07573afc9b 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> > @@ -127,6 +127,7 @@ static const struct emac_variant emac_variant_r40 = {
> > .support_mii = true,
> > .support_rgmii = true,
> > .rx_delay_max = 7,
> > + .tx_delay_max = 7,
> > };
> >
> > static const struct emac_variant emac_variant_a64 = {
> >
>
>
>
>
next prev parent reply other threads:[~2023-12-21 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 9:08 [PATCH] gmac: sun8i: r40: add gmac tx_delay support fuyao
2023-12-20 17:04 ` Jernej Škrabec
2023-12-21 7:16 ` fuyao [this message]
2024-01-02 15:58 ` Jakub Kicinski
2024-01-09 20:15 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYPmZj8l01eQsDS5@debian.cyg \
--to=fuyao@sjterm$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=maijianzhang@allwinnertech$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox