Subject: Re: [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb"

From: Sabrina Dubroca <[email-masked]>
Date: Sun, 21 Jan 2024 10:32:04 +0100

2024-01-18, 11:18:06 -0800, Rahul Rameshbabu wrote:
> This reverts commit b34ab3527b9622ca4910df24ff5beed5aa66c6b5.
> 
> Using skb_ensure_writable_head_tail without a call to skb_unshare causes
> the MACsec stack to operate on the original skb rather than a copy in the
> macsec_encrypt path. This causes the buffer to be exceeded in space, and
> leads to warnings generated by skb_put operations. Opting to revert this
> change since skb_copy_expand is more efficient than
> skb_ensure_writable_head_tail followed by a call to skb_unshare.

Paolo, are you ok with this commit message? I agree it's a bit
confusing but I can't think of anything clearer :(

Other than those details on the commit message (the stack trace could
also have been trimmed a bit), a revert sounds good to me.

-- 
Sabrina