From: Jiri Pirko <jiri@resnulli•us>
To: John Garry <john.g.garry@oracle•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
mcgrof@kernel•org, russ.weight@linux•dev,
gregkh@linuxfoundation•org, rafael@kernel•org,
rostedt@goodmis•org, mhiramat@kernel•org,
mathieu.desnoyers@efficios•com, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com, keescook@chromium•org,
masahiroy@kernel•org, nathan@kernel•org, nicolas@fjasle•eu,
linux-kernel@vger•kernel.org, linux-trace-kernel@vger•kernel.org,
netdev@vger•kernel.org, linux-kbuild@vger•kernel.org
Subject: Re: [PATCH RFC 3/4] net: ethtool: Use uts_release
Date: Thu, 1 Feb 2024 14:20:23 +0100 [thread overview]
Message-ID: <Zbual3uIsjXENw0c@nanopsycho> (raw)
In-Reply-To: <fa2636b8-de7c-494a-bb9c-d1a8cc97f6c8@oracle.com>
Thu, Feb 01, 2024 at 01:57:16PM CET, john.g.garry@oracle•com wrote:
>On 31/01/2024 19:24, Jakub Kicinski wrote:
>> On Wed, 31 Jan 2024 10:48:50 +0000 John Garry wrote:
>> > Instead of using UTS_RELEASE, use uts_release, which means that we don't
>> > need to rebuild the code just for the git head commit changing.
>> >
>> > Signed-off-by: John Garry<john.g.garry@oracle•com>
>> Yes, please!
>>
>> Acked-by: Jakub Kicinski<kuba@kernel•org>
>
>Cheers
>
>BTW, I assume that changes like this are also ok:
>
>--------8<---------
>
> net: team: Don't bother filling in ethtool driver version
>
> The version is same as the default, as don't bother.
>
> Signed-off-by: John Garry <john.g.garry@oracle•com>
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index f575f225d417..0a44bbdcfb7b 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -25,7 +25,6 @@
>#include <net/genetlink.h>
>#include <net/netlink.h>
>#include <net/sch_generic.h>
>-#include <generated/utsrelease.h>
>#include <linux/if_team.h>
>
>#define DRV_NAME "team"
>@@ -2074,7 +2073,6 @@ static void team_ethtool_get_drvinfo(struct
>net_device *dev,
> struct ethtool_drvinfo *drvinfo)
>{
> strscpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
>- strscpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
Yeah. I don't see why should anyone care about this "version"...
Let's remove it.
>}
>
>-------->8---------
>
>right?
>
>John
>
>
>
>
>
next prev parent reply other threads:[~2024-02-01 13:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 10:48 [PATCH RFC 0/4] Introduce uts_release John Garry
2024-01-31 10:48 ` [PATCH RFC 1/4] init: Add uts_release John Garry
2024-01-31 10:48 ` [PATCH RFC 2/4] tracing: Use uts_release John Garry
2024-01-31 19:27 ` Steven Rostedt
2024-01-31 10:48 ` [PATCH RFC 3/4] net: ethtool: " John Garry
2024-01-31 19:24 ` Jakub Kicinski
2024-02-01 12:57 ` John Garry
2024-02-01 13:20 ` Jiri Pirko [this message]
2024-02-01 16:09 ` Jakub Kicinski
2024-02-01 16:20 ` John Garry
2024-01-31 10:48 ` [PATCH RFC 4/4] firmware_loader: " John Garry
2024-01-31 16:22 ` [PATCH RFC 0/4] Introduce uts_release Greg KH
2024-01-31 17:16 ` John Garry
2024-01-31 21:26 ` Greg KH
2024-02-02 15:01 ` Masahiro Yamada
2024-02-02 18:29 ` Jakub Kicinski
2024-02-05 8:25 ` John Garry
2024-02-05 23:10 ` Masahiro Yamada
2024-02-08 10:08 ` John Garry
2024-02-21 9:00 ` John Garry
2024-02-21 11:50 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbual3uIsjXENw0c@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=john.g.garry@oracle$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-trace-kernel@vger$(echo .)kernel.org \
--cc=masahiroy@kernel$(echo .)org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mcgrof@kernel$(echo .)org \
--cc=mhiramat@kernel$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas@fjasle$(echo .)eu \
--cc=pabeni@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=russ.weight@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox