From: Lorenzo Bianconi <lorenzo@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: netdev@vger•kernel.org, lorenzo.bianconi@redhat•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
hawk@kernel•org, ilias.apalodimas@linaro•org
Subject: Re: [PATCH net-next] net: page_pool: make page_pool_create inline
Date: Wed, 14 Feb 2024 20:14:41 +0100 [thread overview]
Message-ID: <Zc0RIWXBnS1TXOnM@lore-desk> (raw)
In-Reply-To: <20240214101450.25ee7e5d@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
> On Wed, 14 Feb 2024 19:01:28 +0100 Lorenzo Bianconi wrote:
> > Make page_pool_create utility routine inline a remove exported symbol.
>
> But why? If you add the kdoc back the LoC saved will be 1.
I would remove the symbol exported since it is just a wrapper for
page_pool_create_percpu()
>
> > include/net/page_pool/types.h | 6 +++++-
> > net/core/page_pool.c | 10 ----------
> > 2 files changed, 5 insertions(+), 11 deletions(-)
>
> No strong opinion, but if you want to do it please put the helper
> in helpers.h Let's keep the static inlines clearly separated.
ack, fine to me. I put it there since we already have some inlines in
page_pool/types.h.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-02-14 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 18:01 [PATCH net-next] net: page_pool: make page_pool_create inline Lorenzo Bianconi
2024-02-14 18:14 ` Jakub Kicinski
2024-02-14 19:14 ` Lorenzo Bianconi [this message]
2024-03-01 10:27 ` Ilias Apalodimas
2024-03-01 10:33 ` Jesper Dangaard Brouer
2024-03-01 10:40 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc0RIWXBnS1TXOnM@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox