From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Herve Codina <herve.codina@bootlin•com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux•dev>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Yury Norov <yury.norov@gmail•com>,
Rasmus Villemoes <linux@rasmusvillemoes•dk>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, Andrew Lunn <andrew@lunn•ch>,
Mark Brown <broonie@kernel•org>,
Christophe Leroy <christophe.leroy@csgroup•eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>
Subject: Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC
Date: Mon, 12 Feb 2024 14:22:56 +0200 [thread overview]
Message-ID: <ZcoNoDRF6h2C7TQd@smile.fi.intel.com> (raw)
In-Reply-To: <20240212075646.19114-2-herve.codina@bootlin.com>
On Mon, Feb 12, 2024 at 08:56:29AM +0100, Herve Codina wrote:
> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
> Multichannel Controller) to transfer the HDLC data.
...
> +#include <linux/dma-mapping.h>
> +#include <linux/hdlc.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_platform.h>
I do not see how these are being used, am I right?
What's is missing OTOH is the mod_devicetable.h.
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
+ Blank line?
> +#include <soc/fsl/qe/qmc.h>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-12 12:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 7:56 [PATCH v3 RESEND 0/6] Add support for QMC HDLC Herve Codina
2024-02-12 7:56 ` [PATCH v3 RESEND 1/6] net: wan: " Herve Codina
2024-02-12 12:22 ` Andy Shevchenko [this message]
2024-02-22 12:05 ` Herve Codina
2024-02-22 13:19 ` Andy Shevchenko
2024-02-22 13:21 ` Herve Codina
2024-02-12 7:56 ` [PATCH v3 RESEND 2/6] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-02-12 7:56 ` [PATCH v3 RESEND 3/6] bitmap: Make bitmap_onto() available to users Herve Codina
2024-02-12 12:27 ` Andy Shevchenko
2024-02-12 13:37 ` Herve Codina
2024-02-12 14:01 ` Andy Shevchenko
2024-02-12 14:20 ` Herve Codina
2024-02-12 14:36 ` Andy Shevchenko
2024-02-12 19:13 ` Yury Norov
2024-02-15 17:46 ` Herve Codina
2024-02-15 19:17 ` Andy Shevchenko
2024-02-21 13:44 ` Herve Codina
2024-02-21 14:30 ` Andy Shevchenko
2024-02-12 7:56 ` [PATCH v3 RESEND 4/6] bitmap: Introduce bitmap_off() Herve Codina
2024-02-12 9:45 ` Rasmus Villemoes
2024-02-12 18:37 ` Yury Norov
2024-02-12 18:41 ` Yury Norov
2024-02-12 7:56 ` [PATCH v3 RESEND 5/6] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-02-12 7:56 ` [PATCH v3 RESEND 6/6] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 0/6] Add support for QMC HDLC Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 1/6] net: wan: " Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 2/6] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 3/6] bitmap: Make bitmap_onto() available to users Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 4/6] bitmap: Introduce bitmap_off() Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 5/6] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-02-12 7:56 ` [RESEND PATCH v3 6/6] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2024-02-12 8:05 ` [PATCH v3 RESEND 0/6] Add support for QMC HDLC Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcoNoDRF6h2C7TQd@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=andrew@lunn$(echo .)ch \
--cc=broonie@kernel$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=herve.codina@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox