Subject: Re: [PATCH net-next v2 1/4] devlink: add two info version tags

From: Jiri Pirko <[email-masked]>
Date: Wed, 28 Feb 2024 13:14:43 +0100

Wed, Feb 28, 2024 at 08:51:37AM CET, [email-masked] wrote:
>From: Fei Qin <[email-masked]>
>
>Add definition and documentation for the new generic
>info "board.model" and "part_number".
>
>Signed-off-by: Fei Qin <[email-masked]>
>Signed-off-by: Louis Peens <[email-masked]>
>---
> Documentation/networking/devlink/devlink-info.rst | 10 ++++++++++
> include/net/devlink.h                             |  5 +++++
> 2 files changed, 15 insertions(+)
>
>diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst
>index 1242b0e6826b..e663975a6b19 100644
>--- a/Documentation/networking/devlink/devlink-info.rst
>+++ b/Documentation/networking/devlink/devlink-info.rst
>@@ -146,6 +146,11 @@ board.manufacture
> 
> An identifier of the company or the facility which produced the part.
> 
>+board.model
>+-----------
>+
>+Board design model.
>+
> fw
> --
> 
>@@ -203,6 +208,11 @@ fw.bootloader
> 
> Version of the bootloader.
> 
>+part_number
>+-----------
>+
>+Part number of the entire product.
>+
> Future work
> ===========
> 
>diff --git a/include/net/devlink.h b/include/net/devlink.h
>index 9ac394bdfbe4..edcd7a1f7068 100644
>--- a/include/net/devlink.h
>+++ b/include/net/devlink.h
>@@ -605,6 +605,8 @@ enum devlink_param_generic_id {
> #define DEVLINK_INFO_VERSION_GENERIC_BOARD_REV	"board.rev"
> /* Maker of the board */
> #define DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE	"board.manufacture"
>+/* Model of the board */
>+#define DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL       "board.model"
> 
> /* Part number, identifier of asic design */
> #define DEVLINK_INFO_VERSION_GENERIC_ASIC_ID	"asic.id"
>@@ -632,6 +634,9 @@ enum devlink_param_generic_id {
> /* Bootloader */
> #define DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER	"fw.bootloader"
> 
>+/* Part number for entire product */
>+#define DEVLINK_INFO_VERSION_GENERIC_PART_NUMBER       "part_number"

/* Part number, identifier of board design */
#define DEVLINK_INFO_VERSION_GENERIC_BOARD_ID   "board.id"

Isn't this what you are looking for?

"part_number" without domain (boards/asic/fw) does not look correct to
me. "Product" sounds very odd.

pw-bot: cr

>+
> /**
>  * struct devlink_flash_update_params - Flash Update parameters
>  * @fw: pointer to the firmware data to update from
>-- 
>2.34.1
>
>