Subject: Re: [PATCH net 1/6] ice: fix connection state of DPLL and out pin

From: Jiri Pirko <[email-masked]>
Date: Thu, 22 Feb 2024 14:22:17 +0100

Thu, Feb 22, 2024 at 01:31:53PM CET, [email-masked] wrote:
>On 20/02/2024 21:44, Tony Nguyen wrote:
>> From: Yochai Hagvi <[email-masked]>
>> 
>> Fix the connection state between source DPLL and output pin, updating the
>> attribute 'state' of 'parent_device'. Previously, the connection state
>> was broken, and didn't reflect the correct state.
>> 
>> When 'state_on_dpll_set' is called with the value
>> 'DPLL_PIN_STATE_CONNECTED' (1), the output pin will switch to the given
>> DPLL, and the state of the given DPLL will be set to connected.
>> E.g.:
>> 	--do pin-set --json '{"id":2, "parent-device":{"parent-id":1,
>> 						       "state": 1 }}'
>> This command will connect DPLL device with id 1 to output pin with id 2.
>> 
>> When 'state_on_dpll_set' is called with the value
>> 'DPLL_PIN_STATE_DISCONNECTED' (2) and the given DPLL is currently
>> connected, then the output pin will be disabled.
>> E.g:
>> 	--do pin-set --json '{"id":2, "parent-device":{"parent-id":1,
>> 						       "state": 2 }}'
>> This command will disable output pin with id 2 if DPLL device with ID 1 is
>> connected to it; otherwise, the command is ignored.
>> 
>> Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
>> Reviewed-by: Wojciech Drewek <[email-masked]>
>> Reviewed-by: Arkadiusz Kubalewski <[email-masked]>
>> Signed-off-by: Yochai Hagvi <[email-masked]>
>> Tested-by: Sunitha Mekala <[email-masked]> (A Contingent worker at Intel)
>> Signed-off-by: Tony Nguyen <[email-masked]>
>> ---
>>   drivers/net/ethernet/intel/ice/ice_dpll.c | 43 +++++++++++++++++------
>>   1 file changed, 32 insertions(+), 11 deletions(-)
>> 
>
>For the series:
>
>Reviewed-by: Vadim Fedorenko <[email-masked]>

I also find this set okay. Feel free to add my rwb tag as well.

Reviewed-by: Jiri Pirko <[email-masked]>